This CL adds a simple regression test for flip_normals().
Tests: add regression test for flip_normals() operator
Docs: minor fix to RunTest.run_test()'s test_name type
Updated blend file should be placed in lib/tests/modeling/operators.blend
Details
Details
- Reviewers
Habib Gahbiche (zazizizou) Himanshi Kalra (calra) Jake (Welp) - Maniphest Tasks
- T84999: Add Operator tests
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- add_operator_flip_normals_regression_test (branched from master)
- Build Status
Buildable 15587 Build 15587: arc lint + arc unit
Event Timeline
Comment Actions
Hi @Andrea Beconcini (beco), thanks for the patch. The patch is fine in principle, however there a few things I would like to suggest:
- Rebase your patch. A few things have changed after this year's GSoC
- Make sure the test can fail, e.g. by flipping normals of the expected object and see if the test can fail.
Also, add a reviewer to your patches in the future so that they get noticed earlier.
Comment Actions
Hi @Habib Gahbiche (zazizizou), thanks for the suggestions.
I'm not really sure how to write the failing case: should I add another expected mesh in the .blend file and compare the result of the flipping operation against the new mesh? Also, I don't know how to mark a SpecMeshTest instance as "expected to fail". Are you aware of any example I can look at?
Comment Actions
I'm not really sure how to write the failing case
That is for local testing only, all tests committed in repo should pass.
It's similar to what's done in TDD: write a failing test with expected results, make changes in code that get the right result and then the test passes. It's to avoid writing always passing tests by accident.
https://en.wikipedia.org/wiki/Test-driven_development#Test-driven_development_cycle
Comment Actions
It's similar to what's done in TDD: write a failing test with expected results, make changes in code that get the right result and then the test passes.
Oh, I did it already then. I created the expected mesh as a simple clone of the test mesh, wrote the test and watched it fail. Then I flipped the normal on the expected object and... profit! (not really earning anything, though 😄 ). I've just done it again, just in case..
Thank you, @Ankit Meel (ankitm) for the explanation.
Let me know if there's anything else I need to do!
Comment Actions
Passes and fails properly. Merged the changes from the .blend in the description with the most recent version and replaced it in the description.