Page MenuHome
Differential D1181

GHash - add optional hash storage in entries
AbandonedPublic
Actions

Authored by Bastien Montagne (mont29) on Mar 13 2015, 1:25 PM.

Details

Reviewers
None
Maniphest Tasks
T43766: GHash Improvements
Summary

Based on D1178, D1179, and D1180.

Note this is put here mostly for sake of consistency, and keep trace of this work. Storing hashes only benefits to keys needing complex, expansive hashing/comparison (i.e. mostly strings), but in Blender currently our string-hashed parts of the code do not really suffer from ghash performance issues, so it adds complexity with no real benefit.

Diff Detail

Event Timeline

Bastien Montagne (mont29) updated this revision to Diff 3739.Mar 13 2015, 1:25 PM
Bastien Montagne (mont29) retitled this revision from to GHash - add optional hash storage in entries.
Bastien Montagne (mont29) updated this object.
Bastien Montagne (mont29) set the repository for this revision to rB Blender.
Bastien Montagne (mont29) added a project: BF Blender.
Bastien Montagne (mont29) added subscribers: Campbell Barton (campbellbarton), Sergey Sharybin (sergey), Lukas Tönne (lukastoenne), Antonis Ryakiotakis (psy-fi).
Bastien Montagne (mont29) added a task: T43766: GHash Improvements.Mar 13 2015, 2:10 PM
Campbell Barton (campbellbarton) added a comment.Mar 18 2015, 3:18 PM

This could be good to have but would really want to see real-world advantage, as tangible benefit for the extra complexity.
.
For now I'd rather just leave it out (some of the other GHash patches you've done seem like they're more beneficial).

source/blender/blenlib/intern/BLI_ghash.c
124

prefer to use flags instead of adding booleans.

Bastien Montagne (mont29) added a comment.Mar 18 2015, 3:22 PM

Yes I agree, I posted it here merely to keep trace of it in case we need it later. :)

Bastien Montagne (mont29) mentioned this in D1155: GHash enhancements..Mar 19 2015, 9:12 PM
Campbell Barton (campbellbarton) added a comment.Mar 25 2015, 4:13 PM

@Bastien Montagne (mont29), could you set this to *Plan Changes*. This patch keeps showing up in our review sessions :)

Bastien Montagne (mont29) planned changes to this revision.Mar 25 2015, 6:36 PM
Bastien Montagne (mont29) abandoned this revision.Mar 14 2019, 10:10 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
2 lines
2 lines
blenlib/
4 lines
intern/
168 lines
bmesh/
tools/
10 lines
editors/
mesh/
2 lines

Diff 3739

View Options

source/blender/blenkernel/intern/cdderivedmesh.c

Loading...
View Options

source/blender/blenkernel/intern/treehash.c

Loading...
View Options

source/blender/blenlib/BLI_ghash.h

Loading...
View Options

source/blender/blenlib/intern/BLI_ghash.c

Loading...
View Options

source/blender/bmesh/tools/bmesh_region_match.c

Loading...
View Options

source/blender/editors/mesh/meshtools.c

Loading...