Differential D11812
Rename Scene's embeded collections from "Master Collection" to "Scene Collection" Authored by Bastien Montagne (mont29) on Jul 5 2021, 3:48 PM.
Details As discussed with @Dalai Felinto (dfelinto). Note that this name is essentially never used anywhere, besides as 'information' mostly accessible from python console. Those embedded IDs are not in Main, so they are not accessible by name ever, and mostly unusable from animation perspective (either drivers or fcurves).
Diff Detail
Event TimelineComment Actions A quick search for "master" in the python files reveals that this is still refer to in those files (in the comments, not as a string):
I wonder if scene->master_collection should be renamed as well. I don't mind the minor discrepancy between the API and the DNA data. But if it is something we can easily do with dna_rename_defs.h I think we may as well. That would mean changing rna_scene.c as well and doing some global rename/replace in the code. PS, why are you not using arcanist Bastien? Comment Actions Will check for the comments in py scripts... Would not change DNA name, would break forward compatibility I think? and we use 'master collection' in C code literally everywhere, that would be a huge (aka noisy) change for very little benefit imho. PS: don't use arcanist when I don't have a branch but just a quick diff on master itself. Comment Actions @Dalai Felinto (dfelinto) checked those py script you mentioned, I don't think those are valid cases really? As in, they are part of 'internal' code, I don't mind keeping those in sync with C code terminology tbh. I thought the only goal of this change was to remove external exposure of the name 'master collection' (i.e. to users through the names of those IDs)? Again, if we want to also remove it from Blender internal code, it's much, much more noisy (and potentially compat breaking) change... |