Page MenuHome

Fix cycles crash when changing viewport display pass
ClosedPublic

Authored by Sergey Sharybin (sergey) on Jul 6 2021, 5:25 PM.

Details

Summary

It was possible that render buffers and scene kernel data will be out
of sync because reset and scene update happens in different locks.

This is similar issue we've fixed in the Cycles X branch, so backported
relevant changes from there.

This change removes what seems to be unused feature kernel.

Seems to work here, but extra testing will be very welcome.

Diff Detail

Repository
rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Jul 6 2021, 5:25 PM
Sergey Sharybin (sergey) created this revision.
Sergey Sharybin (sergey) edited the summary of this revision. (Show Details)Jul 6 2021, 5:26 PM

I tested this on a couple of scenes with CPU and GPU, editing objects, navigating, etc. I could not get it to crash, so seems the backport is correct.

This revision is now accepted and ready to land.Jul 8 2021, 6:10 PM

Thanks for the tests! I'll commit and handle the merge to the cycles-x branch.