Maintain the sign when clamping non zero offset.
In relation to bug T89691, I tested a potential fix, which seems to work correctly in all scenarios.
(this is my first diff, I hope I did it correctly)
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- TEMP-T89691-UPDATE (branched from master)
- Build Status
Buildable 16181 Build 16181: arc lint + arc unit
Event Timeline
Comment Actions
Thanks for looking into that. I actually never entered a value outside the -1 to 1 range, but I understand why you would. I have tested this patch now thoroughly and didn't find anything going particulary wrong in all of the special cases that I know of. Of course things get weird though with intersecting geometry at Y crossings, but that is expected and stable.
The reason I was looking a little closer here, was because I forgot why I had that 1e-5f there. I think the value was not allowed to be zero so I can get some normals by normalizing the position somewhere, but it would take me a while to figure that out again.
This should land soon before the file moves to its new location in GEO.
Comment Actions
Hi, @Henrik Dick (weasel), is there something I need to do regarding this? I am using Blender to develop some tools in a research project, and it would be nice to have this fix in an official build (2.93.x or 3.0).
Comment Actions
While the patch seems OK, there should be a comment explaining why the 1e-5f clamp is needed.