Page MenuHome
Differential D1184

Fix T43898: Sequencer - Ctrl snapping a sequencer strip does not work if you specify the x axis
AbandonedPublic
Actions

Authored by Bastien Montagne (mont29) on Mar 14 2015, 11:47 AM.

Details

Reviewers
Antonis Ryakiotakis (psy-fi)
Maniphest Tasks
T43989: Sequencer - Ctrl snapping a sequencer strip does not work if you specify the x axis
Summary

As title says…

Also makes code a bit better “confined” I think (all snapping cooking is done inside the single snapSequenceBounds).
Now, this is still a bit hackish, especially how we 'disable' increment snapping when constrained, think the best thing would be to create a real seq snapping mode (would also allow to chose between snap to strips of incremental snap!).

Antony, not sure about what we want here…

Diff Detail

Event Timeline

Bastien Montagne (mont29) updated this revision to Diff 3743.Mar 14 2015, 11:47 AM
Bastien Montagne (mont29) retitled this revision from to Fix T43898: Sequencer - Ctrl snapping a sequencer strip does not work if you specify the x axis.
Bastien Montagne (mont29) updated this object.
Bastien Montagne (mont29) added a reviewer: Antonis Ryakiotakis (psy-fi).
Bastien Montagne (mont29) set the repository for this revision to rB Blender.
Bastien Montagne (mont29) added a project: BF Blender.
Bastien Montagne (mont29) added a subscriber: Sergey Sharybin (sergey).
Bastien Montagne (mont29) added a task: T43989: Sequencer - Ctrl snapping a sequencer strip does not work if you specify the x axis.Mar 14 2015, 12:24 PM
Carlo Andreacchio (candreacchio) added a subscriber: Carlo Andreacchio (candreacchio).Mar 15 2015, 5:14 AM
Antonis Ryakiotakis (psy-fi) edited edge metadata.Mar 19 2015, 7:26 PM

The patch is not so good, application will not be done to all strips, only the first. This is coded in a way so that selected strips keep their offset in the selection

Just moving

snap_frame = snapSequenceBounds(t, mval);

before the CON_APPLY check, works here...I didn't understand what was the issue with that, ie which value is snapped to the grid?

It would be good to allow snapping to frames - or seconds too at some point but this is more a TODO than a fix.

Bastien Montagne (mont29) abandoned this revision.Mar 19 2015, 9:02 PM

Committed as rB05e3c261a44b.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
transform/
2 lines
25 lines
11 lines

Diff 3743

View Options

source/blender/editors/transform/transform.h

Loading...
View Options

source/blender/editors/transform/transform.c

Loading...
View Options

source/blender/editors/transform/transform_snap.c

Loading...