Geometry Nodes: Initial socket inspection.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jul 7 2021, 4:10 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Simon Thommes (simonthommes)
Erindale (Erindale)
Miro Horváth (dreamak)

Maniphest Tasks

T89710: Implement socket inspection.

Commits

rB271f34f77e05: Geometry Nodes: initial socket inspection

Summary

The layout of the socket inspection tooltips does not look as nice as in the design yet (T85251). The current implementation is limited by what normal tooltips can show. I'm undecided whether or not this is fine for the initial version. Maybe someone from the ui team know how feasible it is to open a move complex tooltip with a custom layout on hover.

The tooltip for geometries is also very limited for now, much more information could be shown there. This can also be improved after an initial merge though.

Diff Detail

Repository

rB Blender

Branch

temp-socket-inspection (branched from master)

Build Status

Buildable 15686
Build 15686: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jul 7 2021, 4:10 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B15674: Diff 39275.Jul 7 2021, 4:10 PM

Jacques Lucke (JacquesLucke) added a task: T85652: Implement socket inspection and links values.Jul 7 2021, 4:12 PM

Jacques Lucke (JacquesLucke) edited tasks, added T89710: Implement socket inspection.; removed T85652: Implement socket inspection and links values.Jul 7 2021, 4:18 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jul 7 2021, 4:22 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jul 7 2021, 4:25 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jul 7 2021, 4:29 PM

Jacques Lucke (JacquesLucke) added reviewers: Hans Goudey (HooglyBoogly), Simon Thommes (simonthommes), Erindale (Erindale), Miro Horváth (dreamak).

Charlie Jolly (charlie) mentioned this in T86749: Geometry Node Community Additions.Jul 7 2021, 6:02 PM

I wonder if disconnected nodes should be able to be inspected or at least it should be clear why a read-out shows "Unknown"

For usablility I really like that it's just on hover. There's already a lot for people to be aware of with node wrangler and other addons.

Merge branch 'master' into temp-socket-inspection
improve message when socket value is not available

Harbormaster completed remote builds in B15686: Diff 39297.Jul 8 2021, 10:00 AM

Arian (14AUDDIN) awarded a token.Jul 8 2021, 12:02 PM

This is nice, really helpful. I think we should probably talk about the wording of the tooltips though. For example, do we need to say "Geometry Components: Mesh", or just "Mesh", or maybe "Components: Mesh", etc.

I also think using vertical formatting and bullet points could make that sort of component list more readable. I think that's already possible in tooltips.

source/blender/editors/space_node/node_draw.cc
853	Shouldn't these be "else if"?
885	This needs a `TIP_` call to be translated. It should work that way.
989	We need "TIP_" here as well. Also, aren't there other reasons no stored value will be found? Pinning the node editor, when you first open the file?

This revision now requires changes to proceed.Jul 12 2021, 10:07 PM

Merge branch 'master' into temp-socket-inspection
improve tooltip for geometry sockets
support translation

Harbormaster completed remote builds in B15798: Diff 39490.Jul 13 2021, 5:14 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jul 13 2021, 5:18 PM

Looks great!

source/blender/blenkernel/intern/geometry_set.cc
384	Looks like this is unused now.
source/blender/editors/space_node/node_draw.cc
855	I would expand "Boolean" here, I think we do in most other places. Same with Integer above.
957	No need for this cast anymore : )