Fix T89734: Incorrect dependency cycle with id property on modifier.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jul 8 2021, 3:27 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T89734: False dependency cycle when geometry nodes property is driven

Commits

rB192f0c9e17e2: Fix T89734: incorrect dependency cycle with id property on modifier

Summary

This is a follow up fix for rB77834aff223e: Fix T89397: animation in geometry nodes modifier does not update. There were a couple more places where relations were set incorrectly.
I'm not entirely sure about the naming of the function and its place..

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Jul 8 2021, 3:27 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B15694: Diff 39308.Jul 8 2021, 3:27 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Jul 8 2021, 3:31 PM

Jacques Lucke (JacquesLucke) added reviewers: Sergey Sharybin (sergey), Sybren A. Stüvel (sybren).

Jacques Lucke (JacquesLucke) added a task: T89734: False dependency cycle when geometry nodes property is driven.Jul 8 2021, 3:35 PM

I think that rna_prop_affects_parameters_node is quite ok, but may indeed not convey the bigger picture. The comment /* The geometry nodes modifier has its own id properties. */ is a bit weird IMO, as there is no test present to see whether this really is a Geometry Nodes modifier. What does "has its own ID properties" mean in this case?