Page MenuHome
Differential D11872

Bug Fix for Curve Primitive Line - Direction Mode
ClosedPublic
Actions

Authored by Johnny Matthews (guitargeek) on Jul 9 2021, 5:15 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBd7f88982a841: Geometry Nodes: fix direction mode in curve primitive line node
Summary

Direction mode was not taking the start point into consideration when normalizing the direction vector.

Diff Detail

Repository
rB Blender

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Jul 9 2021, 5:15 PM
Johnny Matthews (guitargeek) created this revision.
Erindale (Erindale) added a subscriber: Erindale (Erindale).Jul 9 2021, 5:52 PM

I'd expect the direction to be relative to the start point instead of a point in 3D space it's pointing towards.
In this case a direction of (1,0,0) should always be parallel to the X axis as the start moves around.

Johnny Matthews (guitargeek) updated this revision to Diff 39380.Jul 9 2021, 6:09 PM

I was confused about the proper desired function of this code. This patch makes direction a vector to angle the line rather than a target.

Jacques Lucke (JacquesLucke) accepted this revision.Jul 9 2021, 6:16 PM
This revision is now accepted and ready to land.Jul 9 2021, 6:16 PM
Closed by commit rBd7f88982a841: Geometry Nodes: fix direction mode in curve primitive line node (authored by Johnny Matthews (guitargeek), committed by Jacques Lucke (JacquesLucke)). · Explain WhyJul 9 2021, 6:37 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBd7f88982a841: Geometry Nodes: fix direction mode in curve primitive line node.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
2 lines

Diff 39381

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_primitive_line.cc

Loading...