Page MenuHome

Generic Pose slider Color Change
ClosedPublic

Authored by Christoph Lendenfeld (ChrisLend) on Jul 10 2021, 7:12 PM.

Details

Summary

Depends on D9314

The current implementation uses UI_GetThemeColor4ubv(TH_ACTIVE, color_handle);
This causes an issue because the TH_ACTIVE is different in different contexts. See image below.

Instead use TH_HEADER, TH_HEADER_TEXT and TH_HEADER_TEXT_HI

Old:

New:
3d view

Graph editor

Diff Detail

Repository
rB Blender

Event Timeline

Christoph Lendenfeld (ChrisLend) requested review of this revision.Jul 10 2021, 7:12 PM
Christoph Lendenfeld (ChrisLend) created this revision.

The patch no longer applies cleanly to master, but it's a small fix so that can be fixed while committing.
I'll add @Julian Eisel (Severin) as reviewer so that someone from the UI module has also taken a look.

To me it seems odd to use an accent color like blue for the scale, and a regular white for the value indicator. I'd expect it to be the other way around. @Pablo Vazquez (pablovazquez) what's your take?

I don't think using the numslider theme settings is the way to go.

This is an indicator, not an interactive button. I would rather use:

  • Header background (with opaque alpha so it works on transparent headers) for the background
  • Header text for the lines
  • Header text highlight for the current value/number
Christoph Lendenfeld (ChrisLend) edited the summary of this revision. (Show Details)

change colors to use header theme

Patch no longer applies to current master, could you please update it? Sorry it took so long to check it.

 Cherry Pick Failed!
 Exception 
Command failed with error #1!
COMMAND
git cherry-pick 'arcpatch-D9314'

STDOUT
Auto-merging source/blender/editors/util/ed_draw.c
CONFLICT (content): Merge conflict in source/blender/editors/util/ed_draw.c
Auto-merging source/blender/editors/include/ED_util.h
Auto-merging source/blender/editors/armature/pose_slide.c
CONFLICT (content): Merge conflict in source/blender/editors/armature/pose_slide.c


STDERR
error: could not apply aba4942791f... Generic Slider implementation

UI wise it looks good! Thanks for working on it.

Julian Eisel (Severin) resigned from this revision.Oct 29 2021, 2:04 PM

I asked Pablo to take over the design review (who approved already). So as far as I'm concerned this patch is accepted.

This revision is now accepted and ready to land.Oct 29 2021, 2:04 PM