Page MenuHome
Differential D11894

UI: Support tooltips for superimposed icons
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on Jul 13 2021, 12:25 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Group Reviewers
User Interface
Commits
rB2aca08fc1cb6: UI: Support tooltips for superimposed icons
Summary

In a couple of places in the UI, we show superimposed icons on buttons to execute an operation (called "Extra Icons" internally). Hovering them would show the tooltip of the underlying button, which is misleading and confusing.
There are cases where it's not obvious what an icon does, so a tooltip would be quite useful here. It's likely we are going to use superimposed icons in more places in the future, e.g. see D11890.

Screenshots (mouse cursor is not visible, but it's hovering the icons):

The extra icon basically acts as an override for the button in the tooltip code.

This patch comes from rB2250b5cefee7 with an improvement to also get the operator description for the tooltip. rather than the button's regular description.

Diff Detail

Repository
rB Blender
Branch
temp-extra-icons-tooltips (branched from master)
Build Status
Buildable 15855
Build 15855: arc lint + arc unit

Event Timeline

Julian Eisel (Severin) requested review of this revision.Jul 13 2021, 12:25 PM
Julian Eisel (Severin) created this revision.
Harbormaster completed remote builds in B15785: Diff 39467.Jul 13 2021, 12:25 PM
Julian Eisel (Severin) added a project: User Interface.Jul 13 2021, 12:27 PM
Julian Eisel (Severin) edited the summary of this revision. (Show Details)
Julian Eisel (Severin) edited the summary of this revision. (Show Details)Jul 13 2021, 12:38 PM
Julian Eisel (Severin) updated this revision to Diff 39602.Jul 15 2021, 3:24 PM
  • Speparate string info function for extra icons (based on feedback by Campbell)
Harbormaster completed remote builds in B15855: Diff 39602.Jul 15 2021, 3:24 PM
Julian Eisel (Severin) edited the summary of this revision. (Show Details)Jul 15 2021, 3:25 PM
Campbell Barton (campbellbarton) accepted this revision as: Campbell Barton (campbellbarton).Jul 16 2021, 2:44 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

Noted minor issues, otherwise LGTM.

source/blender/editors/interface/interface.c
7220

This misses Python tool-tips which only show with regular buttons.

This revision is now accepted and ready to land.Jul 16 2021, 2:44 AM
Pablo Vazquez (pablovazquez) awarded a token.Jul 22 2021, 5:01 PM
Julian Eisel (Severin) updated this revision to Diff 40043.Jul 28 2021, 11:40 AM
  • Fix operator Python tooltip text not displayed
Harbormaster completed remote builds in B16080: Diff 40043.Jul 28 2021, 11:40 AM
Julian Eisel (Severin) added inline comments.Jul 28 2021, 11:41 AM
source/blender/editors/interface/interface.c
7220

This is not handled by ui_tooltip_data_from_button_or_extra_icon() but wasn't working correctly. Fixed in the latest update.

Closed by commit rB2aca08fc1cb6: UI: Support tooltips for superimposed icons (authored by Julian Eisel (Severin)). · Explain WhyOct 8 2021, 2:18 PM
This revision was automatically updated to reflect the committed changes.
Julian Eisel (Severin) added a commit: rB2aca08fc1cb6: UI: Support tooltips for superimposed icons.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
10 lines
interface/
84 lines
6 lines
66 lines

Diff 39602

View Options

source/blender/editors/include/UI_interface.h

Loading...
View Options

source/blender/editors/interface/interface.c

Loading...
View Options

source/blender/editors/interface/interface_handlers.c

Loading...
View Options

source/blender/editors/interface/interface_region_tooltip.c

Loading...