Paths

Table of Contentst

Differential D11898

Fix T89826: VSE snapping with constrained axis
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Jul 13 2021, 4:19 PM.

Tags

None

Subscribers

None

Tokens

"Like" token, awarded by PratikPB2123.

Details

Reviewers

Germano Cavalcante (mano-wii)

Maniphest Tasks

T89826: VSE's snap doesn't work when locking X axis

Commits

rB2761679180c3: Fix T89826: VSE snapping with constrained axis

Summary

Constraining to X axis caused snapping to not work at all. Constraining
to Y axis caused snapping indicator to be drawn, when snapping doesn't
occur.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Jul 13 2021, 4:19 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B15794: Diff 39486.Jul 13 2021, 4:19 PM

Germano Cavalcante (mano-wii) added inline comments.Jul 13 2021, 5:08 PM

source/blender/editors/transform/transform_mode_edge_seq_slide.c
132	`t->values` is not supposed to change like that. Can you pass `values_final` as a parameter? t->con.applyVec(t, NULL, NULL, values_final, values_final);

Don't change t->values, reuse values_final for applying constraints

Harbormaster completed remote builds in B15799: Diff 39493.Jul 13 2021, 6:24 PM

Germano Cavalcante (mano-wii) accepted this revision.Jul 13 2021, 7:54 PM

This revision is now accepted and ready to land.Jul 13 2021, 7:54 PM

Pratik Borhade (PratikPB2123) awarded a token.Jul 14 2021, 6:50 AM

Closed by commit rB2761679180c3: Fix T89826: VSE snapping with constrained axis (authored by Richard Antalik (ISS)). · Explain WhyJul 14 2021, 1:24 PM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB2761679180c3: Fix T89826: VSE snapping with constrained axis.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

transform/

transform_mode_edge_seq_slide.c

2 lines

transform_snap_sequencer.c

5 lines

Diff 39529

source/blender/editors/transform/transform_mode_edge_seq_slide.c

Loading...

source/blender/editors/transform/transform_snap_sequencer.c

Loading...