Differential D11916

Flush audio encode after finishing video export
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jul 14 2021, 6:46 PM.

Tags

Subscribers

None

Details

Reviewers

Richard Antalik (ISS)

Commits

rB85c08c9717b1: VSE: Flush audio encode after finishing video export
rB08af3e6e926b: VSE: Flush audio encode after finishing video export

Summary

We didn't flush audio after encoding finished which lead to audio packets being lost.

In addition to this the audio timestamps were wrong also because we incremented the current audio time before encoding it.

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Jul 14 2021, 6:46 PM

Sebastian Parborg (zeddb) created this revision.

Richard Antalik (ISS) accepted this revision.Jul 20 2021, 1:04 AM

This revision is now accepted and ready to land.Jul 20 2021, 1:04 AM

Richard Antalik (ISS) mentioned this in D11918: Fix "off by one" error when encoding audio.Jul 20 2021, 1:35 AM

Sebastian Parborg (zeddb) mentioned this in D11917: Fix audaspace not reading ffmpeg files with start offset correctly.Jul 22 2021, 7:10 PM

Closed by commit rB08af3e6e926b: VSE: Flush audio encode after finishing video export (authored by Sebastian Parborg (zeddb)). · Explain WhyAug 16 2021, 3:14 PM

This revision was automatically updated to reflect the committed changes.

Sebastian Parborg (zeddb) added a commit: rB08af3e6e926b: VSE: Flush audio encode after finishing video export.

Jeroen Bakker (jbakker) added a commit: rB85c08c9717b1: VSE: Flush audio encode after finishing video export.Aug 25 2021, 3:52 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

37 lines

Diff 39553

source/blender/blenkernel/intern/writeffmpeg.c

Loading...