- Adds warning(info) to nodes that don't work when an input value is out of range(Example: Grid Node doesn't work with Vertices X or Verices Y being less than 2)
- Example Info Vertices X must be at least 2
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- InproveWarnings (branched from master)
- Build Status
Buildable 15904 Build 15904: arc lint + arc unit
Event Timeline
| source/blender/nodes/geometry/nodes/node_geo_mesh_subdivide.cc | ||
|---|---|---|
| 86 ↗ | (On Diff #39565) | In what case does this apply? If we don't know, we probably shouldn't be adding an error message. |
Comment Actions
Hi, we talked about this today in the module meeting
We agreed that these are nice in some cases, but they should use the info warning type, and they should only show up in the node, not the terminal or the modifier.
So we should verify that is the case here.
Separately, I think there could be a way to make these a bit nicer. Some sort of utility could be used to generate an output like "'Size X' must be greater than 2".
Comment Actions
- Improve wording
- Change from Warning to Info
- Merge branch 'master' into InproveWarnings
Comment Actions
As suggested in the chat it is better to make those warnings shorter. For example: "Vertices X must be at least 2".