Page MenuHome
Differential D11940

Clang: warn about C++20 designator
ClosedPublic
Actions

Authored by Ankit Meel (ankitm) on Jul 15 2021, 10:24 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Group Reviewers
Platform: macOS
Commits
rB34a05f39be2b: Clang: warn about C++20 designated initializers
Summary

With the ongoing transition to C++ files, windows build
breaks often because of designated initializers.
Now we have two compilers to catch MSVC build error on.

Diff Detail

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Jul 15 2021, 10:24 PM
Ankit Meel (ankitm) created this revision.
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Jul 16 2021, 7:20 AM
Ankit Meel (ankitm) added a reviewer: Platform: macOS.
Ankit Meel (ankitm) updated this revision to Diff 39627.Jul 16 2021, 7:32 AM

remove c99, use c++20 flag only.

Ankit Meel (ankitm) retitled this revision from macOS: warn about C++20/ C99 designator to macOS: warn about C++20 designator.Jul 16 2021, 7:32 AM
Ankit Meel (ankitm) updated this revision to Diff 39640.Jul 16 2021, 12:32 PM

context

Ankit Meel (ankitm) added a reviewer: Sybren A. Stüvel (sybren). Ankit Meel (ankitm) added 1 blocking reviewer(s): Platform: macOS.Jul 16 2021, 12:33 PM

since linux has clang too

Brecht Van Lommel (brecht) accepted this revision.Aug 2 2021, 7:43 PM
Ankit Meel (ankitm) retitled this revision from macOS: warn about C++20 designator to Clang: warn about C++20 designator.Aug 2 2021, 7:44 PM
Campbell Barton (campbellbarton) removed a reviewer: Sybren A. Stüvel (sybren).Aug 21 2021, 10:18 AM
This revision is now accepted and ready to land.Aug 21 2021, 10:18 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).EditedAug 21 2021, 10:26 AM

Testing on Linux with Clang and it works as expected.

CMakeLists.txt
1587

Worth noting that we can drop MSVC 2019 (IIRC), this can be removed.

Campbell Barton (campbellbarton) accepted this revision.Aug 21 2021, 10:29 AM
Closed by commit rB34a05f39be2b: Clang: warn about C++20 designated initializers (authored by Ankit Meel (ankitm)). · Explain WhyAug 21 2021, 10:34 AM
This revision was automatically updated to reflect the committed changes.
Ankit Meel (ankitm) added a commit: rB34a05f39be2b: Clang: warn about C++20 designated initializers.

Revision Contents
Changeset List

PathSize
2 lines

Diff 39620

View Options

CMakeLists.txt

Loading...