This adds the initial (empty) folder structure and CMakeLists.txt file
for the
new geometry module.
The geometry module will be used for shared code between modifiers and
geometry nodes. Header files will be prefixed with GEO.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- geometry_module (branched from master)
- Build Status
Buildable 15866 Build 15866: arc lint + arc unit
Event Timeline
| source/blender/geometry/CMakeLists.txt | ||
|---|---|---|
| 26–27 | Maybe we won't need RNA for this module? I'd hope not anyway. | |
Comment Actions
I'm unsure what I'm being asked to review, there is not a whole lot here? Is this a work in progress and are you asking "is this good start"? probably, no complaints here, thumbs up from me, should you land this as is in master? that be a hard no for me, I'd hold off until the module actually has functionality to offer, I'd expect at-least a blender_add_lib call with a single source/public header file as a minimally useful commit.
Comment Actions
My thinking was it's nice to add the module in a separate commit, not just the first commit that needs to move something to it. That way we can be a bit more purposeful about it, give it a proper commit message, properly define what should be included and what shouldn't, etc.
Maybe that's a bit silly though, I'm not sure.
Comment Actions
I agree with you that it is nice to have this as a initial separate commit. How do we progress here?
Comment Actions
Think you can just commit this new module as part of the first thing that we move into the module. E.g. you could move BKE_volume_to_mesh.hh to the geometry module.