Page MenuHome

Compositor: Full frame Scale node
ClosedPublic

Authored by Manuel Castilla (manzanilla) on Jul 16 2021, 1:43 PM.

Details

Summary

Adds full frame implementation to this node operations.
No functional changes.

Adds init_data method to initialize operation data after
operations are linked and resolutions determined.


init_data is needed because initExecution is called just before
rendering. Data used in get_area_of_interest cannot be
initialized there.
Once tiled implementation is removed initExecution may be renamed
to init_rendering and init_data to init_execution.

Diff Detail

Repository
rB Blender
Branch
cmp-node-scale (branched from master)
Build Status
Buildable 15873
Build 15873: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Jul 16 2021, 1:43 PM
Manuel Castilla (manzanilla) created this revision.
Jeroen Bakker (jbakker) requested changes to this revision.Jul 19 2021, 11:13 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/compositor/operations/COM_ScaleOperation.cc
275

In stead of hiding the warning, we could fix the warning. We could use a different inheritance structure.

This revision now requires changes to proceed.Jul 19 2021, 11:13 AM
  • Fix inheritance structure (adds ScaleRelativeOperation class)
  • Merge branch 'master' into cmp-node-scale
  • Use XRange and YRange
Manuel Castilla (manzanilla) marked an inline comment as done.Jul 20 2021, 11:32 PM
This revision is now accepted and ready to land.Jul 26 2021, 11:23 AM
This revision was automatically updated to reflect the committed changes.