Differential D11953
VSE UI: Correct Mask strip color in default theme Authored by Peter Fog (tintwotin) on Jul 17 2021, 11:04 AM.
Details
In this patch D6883 the default color of mask strips wasn't aligned to the value of mask strip in the light theme. This patch fixes this small inconsistency. The current color of the mask strip is grey. This is problematic since all strips are designed to have non-grey colors, since the greys are reserved the UI and sequencer background.  The light theme in D6883:  The default in D6883: 
Diff Detail Event TimelineComment Actions I don't quite remember what was the intention in D6883. But I don't quite see an issue with having gray strip color. Technically color strip is also gray too. This change must also be done in versioning_userdef.c. Comment Actions I'm pretty sure @Alessio Monti di Sopra (a.monti) and I forgot to align it with the theme. Originally Mask didn't have a themeable color, and when adding it, it got a temp color, and apparently we didn't notice, the default theme still had the temp color when submitting it. Non of the release images, we did, was displaying mask strips. Our design was to give all strips a color(non-grey), but made an exception with the color strip header, since a "neutral" grey made the text readable and affected the content color of the color strip as little as possible. |