Page MenuHome
Differential D11962

Fix T89952: GPencil channel box selection offset
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Jul 19 2021, 12:55 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Group Reviewers
Grease Pencil
Maniphest Tasks
T89952: GPencil: Dopesheet channel box selection is offset
Commits
rB443ae0f22dd8: Fix T89952: GPencil channel box selection offset
rBa70f37bd8a06: Fix T89952: GPencil channel box selection offset
Summary

The channel box selection was offset for grease pencil layers.

This is a proposed fix by @Yann Lanthony (yann-lty)

Before:

After:

Diff Detail

Repository
rB Blender
Branch
T89952 (branched from master)
Build Status
Buildable 15896
Build 15896: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Jul 19 2021, 12:55 PM
Falk David (filedescriptor) created this revision.
Harbormaster completed remote builds in B15896: Diff 39695.Jul 19 2021, 12:55 PM
Falk David (filedescriptor) added a reviewer: Grease Pencil.Jul 19 2021, 12:55 PM
Falk David (filedescriptor) added a project: Grease Pencil.
Falk David (filedescriptor) edited the summary of this revision. (Show Details)
Philipp Oeser (lichtwerk) added a subscriber: Philipp Oeser (lichtwerk).Jul 19 2021, 1:20 PM

Bug was caused by rBd7fb38ddd4af: GPencil: Fix unreported datablock type changed using Dopesheet box select btw.
Solution LGTM.

Pratik Borhade (PratikPB2123) awarded a token.Jul 19 2021, 1:32 PM
Falk David (filedescriptor) added a comment.Jul 19 2021, 2:33 PM

Didn't notice this before, but maybe it would be good to change the comment above the if since it seems to be wrong now with the change.

Antonio Vazquez (antoniov) accepted this revision.Jul 19 2021, 4:52 PM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).

LGTM, just change the comment or maybe remove...you decide.

This revision is now accepted and ready to land.Jul 19 2021, 4:52 PM
Falk David (filedescriptor) updated this revision to Diff 40104.Jul 29 2021, 10:39 AM
  • Merge branch 'master' into T89952
  • Fix comment
Harbormaster completed remote builds in B16109: Diff 40104.Jul 29 2021, 10:39 AM
Closed by commit rBa70f37bd8a06: Fix T89952: GPencil channel box selection offset (authored by Falk David (filedescriptor)). · Explain WhyJul 29 2021, 10:46 AM
This revision was automatically updated to reflect the committed changes.
Falk David (filedescriptor) added a commit: rBa70f37bd8a06: Fix T89952: GPencil channel box selection offset.
Jeroen Bakker (jbakker) added a commit: rB443ae0f22dd8: Fix T89952: GPencil channel box selection offset.Aug 9 2021, 8:43 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
animation/
1 line

Diff 39695

View Options

source/blender/editors/animation/anim_channels_edit.c

Loading...