Details

Reviewers

Jesse Yurkovich (deadpin)
Jeroen Bakker (jbakker)

Commits

rB9cc8d50a046f: cleanup: editor_image : Remove unused draw functions

Summary

These functions are unused currently..

Diff Detail

Repository: rB Blender

Event Timeline

jim man (jimman2003) requested review of this revision.Jul 19 2021, 10:05 PM

jim man (jimman2003) created this revision.

jim man (jimman2003) retitled this revision from cleanup: editors:Remove draw_image_main to cleanup: editor_image :Remove draw_image_main.

jim man (jimman2003) retitled this revision from cleanup: editor_image :Remove draw_image_main to cleanup: editor_image : Remove unused draw_image_main.Jul 19 2021, 10:16 PM

jim man (jimman2003) edited the summary of this revision. (Show Details)

jim man (jimman2003) edited the summary of this revision. (Show Details)Jul 19 2021, 10:21 PM

With the removal in this patch, I think the following functions are also now dead and can probably be cleaned up at the same time I think:
draw_image_buffer_repeated
draw_image_buffer
draw_udim_label
draw_udim_tile_grid
draw_udim_tile_grids

There are a few more static functions inside this file that might also be removable after the above. Take another pass and see.

This revision now requires changes to proceed.Jul 19 2021, 11:00 PM

Removed the suggested functions..

There are a few remaining in the same file still:
sima_draw_zbuf_pixels
sima_draw_zbuffloat_pixels
draw_image_grease_pencil (including declaration in the header file)

There's a decent chance many of the #includes can now be removed as well. I think there's a script somewhere to run that might be able to help here but I've never run it or know how to. Will let others chime in on if that's something to do for this patch as well.

jim man (jimman2003) retitled this revision from cleanup: editor_image : Remove unused draw_image_main to cleanup: editor_image : Remove unused functions .Jul 20 2021, 9:23 PM

jim man (jimman2003) edited the summary of this revision. (Show Details)

jim man (jimman2003) retitled this revision from cleanup: editor_image : Remove unused functions to cleanup: editor_image : Remove unused draw functions .Jul 20 2021, 9:29 PM

jim man (jimman2003) updated this revision to Diff 39755.Jul 20 2021, 10:36 PM

jim man (jimman2003) updated this revision to Diff 39756.

jim man (jimman2003) mentioned this in D11994: Cleanup: Remove unused image drawing code.Jul 22 2021, 12:59 PM

@Jesse Yurkovich (deadpin) are there still non-addressed points from your review?

@Sergey Sharybin (sergey) It looks good from my side. I just didn't accept the review because I wasn't sure how to ensure it would still get a review from someone else (I know how to do that now though in the future)

Jeroen Bakker (jbakker) accepted this revision.Jul 23 2021, 12:21 PM

Jesse Yurkovich (deadpin) accepted this revision.Jul 28 2021, 7:09 PM

This revision is now accepted and ready to land.Jul 28 2021, 7:09 PM

Closed by commit rB9cc8d50a046f: cleanup: editor_image : Remove unused draw functions (authored by jim man (jimman2003), committed by Sergey Sharybin (sergey)). · Explain WhyJul 29 2021, 12:53 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB9cc8d50a046f: cleanup: editor_image : Remove unused draw functions.