Page MenuHome

Feature: Sequencer python API sequence.parent_meta()
ClosedPublic

Authored by Félix (Miadim) on Jul 21 2021, 2:19 PM.

Details

Summary

To test it create a sequence, and metastrip it. Then, using the python console, find the metastripped sequence and run sequence.parent_meta().

Diff Detail

Repository
rB Blender
Branch
ft_get_hierachy (branched from master)
Build Status
Buildable 15933
Build 15933: arc lint + arc unit

Event Timeline

Félix (Miadim) requested review of this revision.Jul 21 2021, 2:19 PM
Félix (Miadim) created this revision.
Félix (Miadim) edited the summary of this revision. (Show Details)Jul 21 2021, 2:21 PM
Richard Antalik (ISS) requested changes to this revision.Jul 24 2021, 5:29 AM

Seems to work well, got mostly style issues.

source/blender/compositor/operations/COM_SMAAOperation.cc
22

Unrelated change

source/blender/makesrna/intern/rna_sequencer_api.c
680

Usually functions like this should follow convention something_something_get, assumption is, that you may have _set function too. here is no set function so you can also use just Sequence.parent_meta without "get"

684

This is description of returned type, so "Get x" is not quite applicable.
parm = RNA_def_pointer(func, "sequence", "Sequence", "", "Parent meta");

source/blender/sequencer/intern/strip_relations.c
508–517

I think it's best to add seq_find_metastrip_by_sequence to header directly with uppercase SEQ_ prefix, since SEQ_get_parent_meta is not providing any aditional functionality.

This revision now requires changes to proceed.Jul 24 2021, 5:29 AM
source/blender/compositor/operations/COM_SMAAOperation.cc
22

This is because of make format, I'll try to remove it to from the commit then...

Félix (Miadim) marked 2 inline comments as done.
  • Required Changes
Félix (Miadim) marked 2 inline comments as done.Jul 26 2021, 12:58 PM
Félix (Miadim) edited the summary of this revision. (Show Details)
Félix (Miadim) retitled this revision from Feature: Sequencer python API sequence.get_parent_meta() to Feature: Sequencer python API sequence.parent_meta().Jul 26 2021, 1:03 PM
This revision is now accepted and ready to land.Jul 27 2021, 2:45 PM