Paths

Table of Contentst

Differential D11991

Cleanup: Rearrange files used for mesh extraction
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Jul 21 2021, 8:59 PM.

Details

Reviewers

Jeroen Bakker (jbakker)
Clément Foucault (fclem)

Commits

rB3059853732d7: Cleanup: Rearrange mesh extraction files

Summary

The draw module has a folder containing different types of buffer extractors - draw\intern\mesh_extractors.

However, it is not easy to identify what its header is, and where the shared functions are.

This patch proposes to move draw_cache_extract_mesh_extractors.c and draw_cache_extract_mesh_private.h to the same folder as the extractors and rename these files to make them more identifiable.

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Jul 21 2021, 8:59 PM

Germano Cavalcante (mano-wii) created this revision.

Harbormaster completed remote builds in B15944: Diff 39787.Jul 21 2021, 8:59 PM

Germano Cavalcante (mano-wii) added a reviewer: Clément Foucault (fclem).Jul 22 2021, 8:20 PM

Jeroen Bakker (jbakker) accepted this revision.Jul 26 2021, 11:56 AM

This revision is now accepted and ready to land.Jul 26 2021, 11:56 AM

Closed by commit rB3059853732d7: Cleanup: Rearrange mesh extraction files (authored by Germano Cavalcante (mano-wii)). · Explain WhyJul 26 2021, 3:28 PM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rB3059853732d7: Cleanup: Rearrange mesh extraction files.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

CMakeLists.txt

4 lines

intern/

draw_cache_extract_mesh.cc

3 lines

draw_cache_extract_mesh_extractors.c

draw_cache_extract_mesh_private.h

draw_cache_extract_mesh_render_data.c

2 lines

draw_cache_impl_mesh.c

3 lines

	mesh_extractors/

	extract_mesh.h
	draw_cache_extract_mesh_private.h

	extract_mesh.c
	draw_cache_extract_mesh_extractors.c

3 lines

mesh_extractors/

extract_mesh_ibo_edituv.cc

4 lines

extract_mesh_ibo_fdots.cc

4 lines

extract_mesh_ibo_lines.cc

4 lines

extract_mesh_ibo_lines_adjacency.cc

4 lines

extract_mesh_ibo_lines_paint_mask.cc

4 lines

extract_mesh_ibo_points.cc

4 lines

extract_mesh_ibo_tris.cc

4 lines

extract_mesh_vbo_edge_fac.cc

2 lines

extract_mesh_vbo_edit_data.cc

3 lines

extract_mesh_vbo_edituv_data.cc

3 lines

extract_mesh_vbo_edituv_stretch_angle.cc

2 lines

extract_mesh_vbo_edituv_stretch_area.cc

2 lines

extract_mesh_vbo_fdots_edituv_data.cc

3 lines

extract_mesh_vbo_fdots_nor.cc

2 lines

extract_mesh_vbo_fdots_pos.cc

2 lines

extract_mesh_vbo_fdots_uv.cc

2 lines

extract_mesh_vbo_lnor.cc

2 lines

extract_mesh_vbo_mesh_analysis.cc

2 lines

extract_mesh_vbo_orco.cc

2 lines

extract_mesh_vbo_pos_nor.cc

2 lines

extract_mesh_vbo_sculpt_data.cc

2 lines

extract_mesh_vbo_select_idx.cc

2 lines

extract_mesh_vbo_skin_roots.cc

2 lines

extract_mesh_vbo_tan.cc

2 lines

extract_mesh_vbo_uv.cc

2 lines

extract_mesh_vbo_vcol.cc

2 lines

extract_mesh_vbo_weights.cc

2 lines

tools

2 lines

Diff 39959

View Options

source/blender/draw/CMakeLists.txt

View Options

source/blender/draw/intern/draw_cache_extract_mesh.cc

View Options

source/blender/draw/intern/draw_cache_extract_mesh_extractors.c

View Options

source/blender/draw/intern/draw_cache_extract_mesh_private.h

View Options

source/blender/draw/intern/draw_cache_extract_mesh_render_data.c

View Options

source/blender/draw/intern/draw_cache_impl_mesh.c

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh.h

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh.c

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_edituv.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_fdots.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines_adjacency.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines_paint_mask.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_points.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_tris.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edge_fac.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edit_data.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edituv_data.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edituv_stretch_angle.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edituv_stretch_area.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_fdots_edituv_data.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_fdots_nor.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_fdots_pos.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_fdots_uv.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_lnor.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_mesh_analysis.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_orco.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_pos_nor.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_sculpt_data.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_select_idx.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_skin_roots.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_tan.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_uv.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_vcol.cc

View Options

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_weights.cc

View Options

Cleanup: Rearrange files used for mesh extractionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39959

source/blender/draw/CMakeLists.txt

source/blender/draw/intern/draw_cache_extract_mesh.cc

source/blender/draw/intern/draw_cache_extract_mesh_extractors.c

source/blender/draw/intern/draw_cache_extract_mesh_private.h

source/blender/draw/intern/draw_cache_extract_mesh_render_data.c

source/blender/draw/intern/draw_cache_impl_mesh.c

source/blender/draw/intern/mesh_extractors/extract_mesh.h

source/blender/draw/intern/mesh_extractors/extract_mesh.c

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_edituv.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_fdots.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines_adjacency.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines_paint_mask.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_points.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_tris.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edge_fac.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edit_data.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edituv_data.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edituv_stretch_angle.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_edituv_stretch_area.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_fdots_edituv_data.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_fdots_nor.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_fdots_pos.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_fdots_uv.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_lnor.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_mesh_analysis.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_orco.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_pos_nor.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_sculpt_data.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_select_idx.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_skin_roots.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_tan.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_uv.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_vcol.cc

source/blender/draw/intern/mesh_extractors/extract_mesh_vbo_weights.cc

source/tools

Cleanup: Rearrange files used for mesh extraction
ClosedPublic
Actions

Revision Contents
Changeset List