Page MenuHome
Differential D12015

Cycles X: remove all alignment requirements in render passes storage
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Jul 23 2021, 6:35 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rB6eca3ca715f7: Cycles X: remove all alignment requirements in render passes storage
Summary

This saves memory, simplifies the code and has no apparent performance
impact. Whatever historical reasons there were for this, I don't think
they apply anymore.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Jul 23 2021, 6:35 PM
Brecht Van Lommel (brecht) created this revision.
Harbormaster completed remote builds in B15997: Diff 39883.Jul 23 2021, 6:35 PM
Sergey Sharybin (sergey) added a comment.Jul 23 2021, 6:49 PM

Did you check performance on both CPU and GPU?

Brecht Van Lommel (brecht) added a comment.Jul 23 2021, 7:00 PM

Yes, I found no measurable difference with either.

Sergey Sharybin (sergey) accepted this revision.Jul 23 2021, 7:14 PM

Interesting. And is indeed simplifies code quite a bit.

This revision is now accepted and ready to land.Jul 23 2021, 7:14 PM
Closed by commit rB6eca3ca715f7: Cycles X: remove all alignment requirements in render passes storage (authored by Brecht Van Lommel (brecht)). · Explain WhyJul 23 2021, 7:30 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB6eca3ca715f7: Cycles X: remove all alignment requirements in render passes storage.
Lukas Stockner (lukasstockner97) mentioned this in D14595: Fix T97159: AOV Pass in Cycles always gets Alpha Value of 1 for whole image.Apr 8 2022, 1:19 AM

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
addon/
2 lines
integrator/
50 lines
kernel/
3 lines
19 lines
6 lines
4 lines
44 lines
svm/
4 lines
render/
2 lines
41 lines
2 lines
18 lines
5 lines
27 lines
2 lines

Diff 39887

View Options

intern/cycles/blender/addon/engine.py

Loading...
View Options

intern/cycles/integrator/pass_accessor.cpp

Loading...
View Options

intern/cycles/kernel/kernel_accumulate.h

Loading...
View Options

intern/cycles/kernel/kernel_film.h

Loading...
View Options

intern/cycles/kernel/kernel_passes.h

Loading...
View Options

intern/cycles/kernel/kernel_types.h

Loading...
View Options

intern/cycles/kernel/kernel_write_passes.h

Loading...
View Options

intern/cycles/kernel/svm/svm_aov.h

Loading...
View Options

intern/cycles/render/buffers.cpp

Loading...
View Options

intern/cycles/render/film.cpp

Loading...
View Options

intern/cycles/render/nodes.h

Loading...
View Options

intern/cycles/render/nodes.cpp

Loading...
View Options

intern/cycles/render/pass.h

Loading...
View Options

intern/cycles/render/pass.cpp

Loading...
View Options

intern/cycles/render/svm.cpp

Loading...