Differential D12036

Fix T90153: Curve guides don't work on mesh-to-curve objects
Needs ReviewPublic
Actions

Authored by Christopher Burns (christopher.burns) on Jul 27 2021, 1:46 AM.

Details

Reviewers: None
Maniphest Tasks: T90153: Curve guides don't work on mesh-to-curve objects

Summary

When a new Bezier curve is created, the "Path Animation" is checked (enabled) by default. This patch modifies "Convert to Curve" to also enable "Path Animation" by default, which ultimately fixes the crash described in T90153

Diff Detail

Event Timeline

Christopher Burns (christopher.burns) requested review of this revision.Jul 27 2021, 1:46 AM

Christopher Burns (christopher.burns) created this revision.

Christopher Burns (christopher.burns) mentioned this in T90153: Curve guides don't work on mesh-to-curve objects.

Pratik Borhade (PratikPB2123) retitled this revision from Fix for T90153 to Fix T90153: Curve guides don't work on mesh-to-curve objects.Jul 27 2021, 2:56 AM

Pratik Borhade (PratikPB2123) added a task: T90153: Curve guides don't work on mesh-to-curve objects.

Pratik Borhade (PratikPB2123) added projects: Modeling, Animation & Rigging.

Pratik Borhade (PratikPB2123) awarded a token.

So the default behavior is one thing, but the more basic issue is that the app crashes in BKE_where_on_path when "Path Animation" is disabled. This update adds a check that returns false from BKE_where_on_path if anim_path_accum_length is NULL

Iyad Ahmed (iyadahmed2001) awarded a token.Aug 16 2021, 4:21 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

mesh_convert.c

2 lines

Diff 39978

View Options

source/blender/blenkernel/intern/mesh_convert.c

Fix T90153: Curve guides don't work on mesh-to-curve objectsNeeds ReviewPublicActions