Fix: script.reload() operator reloads current app template
ClosedPublic
Actions

Authored by Félix (Miadim) on Jul 27 2021, 4:22 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T78500: Application Template: script.reload() doesn't reload app template

Summary

Fixes T78500

Diff Detail

Repository

rB Blender

Branch

fx_app_template_reload (branched from master)

Build Status

Buildable 16067
Build 16067: arc lint + arc unit

Event Timeline

Félix (Miadim) requested review of this revision.Jul 27 2021, 4:22 PM

Félix (Miadim) created this revision.

Harbormaster completed remote builds in B16067: Diff 40013.Jul 27 2021, 4:22 PM

Félix (Miadim) mentioned this in T78500: Application Template: script.reload() doesn't reload app template.Jul 27 2021, 4:24 PM

Campbell Barton (campbellbarton) requested changes to this revision.Jul 27 2021, 6:19 PM

Campbell Barton (campbellbarton) added inline comments.

release/scripts/modules/bl_app_template_utils.py
174–175	`_disable` expects a template, if it's an empty string, it doesn't make sense to run the disable function.

This revision now requires changes to proceed.Jul 27 2021, 6:19 PM

Fix: Correction for _disable condition

Harbormaster completed remote builds in B16079: Diff 40040.Jul 28 2021, 11:09 AM

Campbell Barton (campbellbarton) mentioned this in rBa787bcbf5c97: Fix: script.reload() operator reloads current app template.Jul 30 2021, 1:54 PM

Hi @Campbell Barton (campbellbarton), is my change fine for you?

Committed but this didn't auto-close.

This revision is now accepted and ready to land.Aug 16 2021, 11:57 AM

Campbell Barton (campbellbarton) closed this revision.Aug 16 2021, 11:57 AM

Revision Contents
Changeset List

Path

Size

release/

scripts/

modules/

bl_app_template_utils.py

10 lines

Diff 40013

View Options

release/scripts/modules/bl_app_template_utils.py

Fix: script.reload() operator reloads current app templateClosedPublicActions