I think it would be nicer design, if there would be only sequence_editor.display_stack() function and you can provide either sequence or None. So you can do sequence_editor.display_stack(sequence_editor.meta_stack[-1]) to go up one level for example.

I have pretty much same argument for sequencer.meta_toggle operator, I would rather keep it in C as it is core functionality and we may want to modify it in a way, that wouldn't be possible in python.

Changing displayed stack seems to work, but this doenn't refresh view properly and I can see strips from parent stack until I click somewhere. I think this may be because selection must be cleared in all other stacks (in practice only last displayed), but I may be mistaken.

I agree about the design you propose. It's cleaner. I'll change that.

About the operator, maybe I didn't fix everything correctly, I'll have a look.

Regarding the fact we should keep it in C, I believe, and also I need, to be able to override this kind of operators for my project (Stax). I need to handle Blender native operators with some extra operations to make it transparent for users: they use Blender as they're used to doing it, but Stax does more things in background. If they want to keep using their shortcuts and not Stax's keymap. Currently, I'm forced to create a sequencer.toggle_meta to override the sequencer.meta_toggle and to force Stax's keymap installation at startup, else this operator would be accessible only in the UI and breaks Blender workflow consistency.
I agree we may face a case where an additional feature doesn't exist yet in Python, but a great design would be to have all the python's API functions for core C functions we need to have exposed, and manage operators only in Python.

Keep meta_toggle operator to C and API: sequence_editor.display_stack(meta_seq or None)

Harbormaster completed remote builds in B17292: Diff 42379.Sep 24 2021, 3:12 PM

Feature: sequence_editor.display_stack(meta_seq) function

Harbormaster completed remote builds in B17297: Diff 42395.Sep 24 2021, 8:09 PM

Feature: sequence_editor.display_stack(meta_seq) function

Harbormaster completed remote builds in B17298: Diff 42396.Sep 24 2021, 8:15 PM

Félix (Miadim) edited the summary of this revision. (Show Details)Sep 24 2021, 8:17 PM

There are some issues with functionality.

When "opening" meta strip, strips from different seqbase are visible. I think this is because strip is selected and drawing code treats this in special way. We should restrict this code to only draw strips in current seqbase. But not 100% sure this is actually what is causing problems. Don't see anything wrong with code in this regard at least...
You can enter non-meta strip via python API, that shouldn't be possible to do. I think python function should report error in this case.
Executing C.scene.sequence_editor.display_stack(None) in top seqbase will cause crash, because SEQ_meta_stack_active_get will return NULL

Otherwise this looks nice.

This revision now requires changes to proceed.Nov 22 2021, 5:41 AM

Feature: sequence_editor.display_stack(meta_seq) function
Sentinel for non-meta seq
Safe display_stack(None)
Fill seq_ed.meta_stack with created SEQ_get_sequence_metas_ancestors

Harbormaster completed remote builds in B21061: Diff 49328.Mar 16 2022, 11:50 AM

@Richard Antalik (ISS) I'd like to add a sequence.metas_hierarchy() which would return the whole tree of metas to the sequence, using the SEQ_get_sequence_metas_ancestors function I introduced here. Shall I add it there or create a new patch when this one will be applied?

Félix (Miadim) edited the summary of this revision. (Show Details)Mar 16 2022, 11:55 AM

Félix (Miadim) added a subscriber: Élie Michel (elie).

Functionally this looks good.

Now first comment in code, actually may be doable to have only one function, because I wanted to suggest - I think, that the code from rna_SequenceEditor_display_stack which is functional, should actually go to SEQ_display_stack, otherwise I don't think there is even need for having function SEQ_display_stack. In other words, it is not adding any API functionality, only wrapping existing functionality. I will try to do quick diff as example of how this could work.

source/blender/editors/space_sequencer/sequencer_edit.c
1884–1891	I don't think this change is necessary. Since you don't do jumps more than 1 level, I would assume it would be guaranteed, that `parent_meta->seqbase == ms->oldbasep` so there is no need to use `SEQ_find_metastrip_by_sequence` at all. On one hand if I know nothing about how this works and I step through the code, this may be quite confusing + adds unnecessary tree traversing, which is not great to add unless there is good reason. On the other hand, there is potential to make this more elegant by eventually elliminating metastack visibility for operators and have only one function for navigation between meta strips, but this would need more work or even design change. So I am undecided here, but would lean towards not changing this operator at all and just adding comment like "TODO: make `SEQ_display_stack` handle `MetaStack` internally so there is only 1 function needed for navigation".
source/blender/makesrna/intern/rna_sequencer.c
1129	Eh, what is "sentinel"? Also add fullstop at the end of comments.
1136	You can't just clear `ListBase`, you will have to free elements or you will cause memory leak. `BLI_freelistN` does free elements and removes them from list.
source/blender/sequencer/SEQ_relations.h
67 ↗	(On Diff #49328)	I guess this should be `SEQ_get_sequence_metas_ancestors`
source/blender/sequencer/intern/strip_relations.c
475 ↗	(On Diff #49328)	Prefer using `LISTBASE_FOREACH` for iterating - `LISTBASE_FOREACH (Sequence *, iseq, seqbase)`
482 ↗	(On Diff #49328)	`!BLI_listbase_is_empty(&iseq->seqbase)` is semantically cleaner and may be even faster by 1.5 CPU cycles :)

So in this patch (P2877), I moved functional stuff to SEQ_display_stack. This allowed me to make SEQ_get_sequence_metas_ancestors static, which allowed me to get rid of passing data via ListBase.

I have renamed these functions to SEQ_meta_stack_set and seq_meta_stack_set_recursive just to not introduce another terms. IMO even display_stack rna function should be renamed to meta_stack_set, since this meta stack is used and known term. maybe even meta_stack_active_set, since there is SEQ_meta_stack_active_get? Not sure, but these are details.

Now back to meta toggle operator, entering meta strip is reduced basically to simple SEQ_meta_stack_set call which is nice. no need to manually alloc or free anything, so these functions can be hidden. but exitting meta is still not nice, so I propose meta_stack_pop function, which can be used for this operator. Still not too great, because this selects strip, which is stored in MetaStack, so there still needs to be SEQ_meta_stack_active_get. However, I can return this strip as reference. So now there is no need to manipulate data manually, all is covered by API. Function SEQ_meta_stack_active_get s still used internally, so I can move it to sequencer.h file with lowercase seq prefix.

I have written this as I went along and modified the code, so hopefully you can follow my train of logic. Patch will show you only final modified version... Also sorry for not making my patch clean, mainly wanted to do quick edits that work (even that is not quite guaranteed, eh)

Also forgot to mention, that now function documentation comments are moved to header files.

Following @Richard Antalik (ISS) recommendations for code design

Harbormaster completed remote builds in B22700: Diff 52916.Jun 26 2022, 11:48 PM

Fixed code guidelines

Harbormaster completed remote builds in B22701: Diff 52917.Jun 27 2022, 12:07 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 27 2022, 7:44 PM

Closed by commit rB6b35d9e6fbef: VSE: Add API function to select displayed meta strip (authored by Felix Gremse (felix), committed by Richard Antalik (ISS)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB6b35d9e6fbef: VSE: Add API function to select displayed meta strip.

Large Diff

This large diff affects 171 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

build_files/

build_environment/

install_deps.sh

2 lines

cmake/

platform/

platform_win32_bundle_crt.cmake

9 lines

config/

pipeline_config.json

pipeline_config.yaml

69 lines

extern/

audaspace/

bindings/

AUD_Special.cpp

4 lines

AUD_Types.h

1 line

include/

IReader.h

6 lines

fx/

VolumeReader.h

2 lines

plugins/

ffmpeg/

FFMPEGReader.h

17 lines

FFMPEGReader.cpp

80 lines

src/

fx/

VolumeReader.cpp

2 lines

intern/

cycles/

blender/

blender_object.cpp

12 lines

blender_sync.h

6 lines

blender_sync.cpp

31 lines

device/

cuda/

device_cuda_impl.cpp

9 lines

kernel/

CMakeLists.txt

9 lines

ffmpeg/

ffmpeg_compat.h

589 lines

release/

freedesktop/

org.blender.Blender.appdata.xml

19 lines

scripts/

freestyle/

modules/

freestyle/

shaders.py

6 lines

modules/

bpy_types.py

12 lines

startup/

bl_operators/

geometry_nodes.py

5 lines

rigidbody.py

21 lines

bl_ui/

properties_collection.py

10 lines

3 lines

7 lines

1 line

2 lines

source/

blender/

blenfont/

intern/

blf_glyph.c

2 lines

blenkernel/

BKE_blender_version.h

6 lines

3 lines

2 lines

2 lines

11 lines

9 lines

4 lines

intern/

2 lines

5 lines

9 lines

8 lines

6 lines

103 lines

1 line

6 lines

35 lines

15 lines

12 lines

2 lines

1 line

1 line

1 line

16 lines

555 lines

blenlib/

BLI_math_vector.h

6 lines

intern/

9 lines

15 lines

15 lines

2 lines

blenloader/

intern/

versioning_290.c

30 lines

bmesh/

operators/

bmo_smooth_laplacian.c

27 lines

tools/

bmesh_region_match.c

3 lines

compositor/

nodes/

COM_CryptomatteNode.cc

14 lines

draw/

engines/

eevee/

eevee_renderpasses.c

2 lines

gpencil/

gpencil_engine.h

4 lines

image/

image_engine.c

39 lines

intern/

draw_manager_texture.c

24 lines

editors/

animation/

anim_channels_edit.c

3 lines

time_scrub_ui.c

4 lines

armature/

pose_slide.c

6 lines

gpencil/

gpencil_select.c

8 lines

gpencil_utils.c

8 lines

interface/

interface_eyedropper_color.c

98 lines

interface_handlers.c

19 lines

io/

io_alembic.c

36 lines

mesh/

editmesh_extrude_spin_gizmo.c

4 lines

editmesh_knife_project.c

9 lines

editmesh_select.c

6 lines

editmesh_tools.c

26 lines

editmesh_undo.c

2 lines

object/

2 lines

7 lines

2 lines

47 lines

physics/

particle_object.c

5 lines

render/

render_preview.c

5 lines

render_shading.c

9 lines

screen/

screen_edit.c

8 lines

screen_ops.c

34 lines

sculpt_paint/

paint_stroke.c

2 lines

space_buttons/

buttons_context.c

15 lines

space_buttons.c

8 lines

space_clip/

clip_editor.c

1 line

space_nla/

nla_channels.c

3 lines

space_node/

node_draw.cc

38 lines

space_sequencer/

sequencer_add.c

28 lines

sequencer_draw.c

330 lines

sequencer_edit.c

7 lines

space_view3d/

view3d_buttons.c

1 line

view3d_draw.c

3 lines

transform/

2 lines

5 lines

14 lines

3 lines

transform_mode_translate.c

59 lines

transform_snap.c

29 lines

uvedit/

uvedit_ops.c

4 lines

uvedit_smart_stitch.c

8 lines

gpencil_modifiers/

intern/

MOD_gpencillineart.c

3 lines

lineart/

MOD_lineart.h

3 lines

lineart_cpu.c

10 lines

gpu/

GPU_shader.h

1 line

GPU_texture.h

14 lines

intern/

gpu_material.c

1 line

opengl/

gl_backend.cc

38 lines

shaders/

gpu_shader_text_frag.glsl

2 lines

imbuf/

CMakeLists.txt

6 lines

IMB_imbuf.h

7 lines

intern/

12 lines

11 lines

625 lines

378 lines

494 lines

16 lines

io/

alembic/

ABC_alembic.h

4 lines

exporter/

abc_export_capi.cc

3 lines

abc_writer_abstract.cc

2 lines

abc_writer_mesh.cc

2 lines

makesdna/

1 line

1 line

24 lines

2 lines

2 lines

1 line

intern/

makesdna.c

69 lines

makesrna/

intern/

2 lines

2 lines

13 lines

7 lines

32 lines

5 lines

modifiers/

intern/

MOD_boolean.cc

2 lines

MOD_nodes.cc

12 lines

MOD_skin.c

63 lines

nodes/

NOD_derived_node_tree.hh

1 line

NOD_math_functions.hh

2 lines

NOD_node_tree_ref.hh

13 lines

composite/

nodes/

node_composite_cryptomatte.cc

124 lines

intern/

derived_node_tree.cc

10 lines

node_tree_ref.cc

15 lines

shader/

node_shader_tree.c

1 line

nodes/

node_shader_output_aov.c

5 lines

python/

bmesh/

bmesh_py_types.c

34 lines

bmesh_py_types_customdata.c

2 lines

bmesh_py_types_select.c

21 lines

gpu/

gpu_py_texture.c

6 lines

intern/

bpy_props.c

18 lines

bpy_rna.c

4 lines

bpy_rna_gizmo.c

7 lines

bpy_rna_id_collection.c

13 lines

mathutils/

mathutils.c

4 lines

render/

intern/

bake.c

4 lines

sequencer/

SEQ_add.h

6 lines

SEQ_sequencer.h

1 line

intern/

2 lines

21 lines

7 lines

53 lines

4 lines

windowmanager/

intern/

wm.c

1 line

wm_event_query.c

2 lines

tests/

python/

alembic_export_tests.py

18 lines

bl_alembic_io_test.py

1 line

Commit	Tree	Parents	Author	Summary	Date
ee8d3afa7d00	f6ba676cc2f1	b7205031cec4	Félix David	Feature: sequence_editor.display_stack(meta_seq) function	Sep 24 2021, 8:06 PM
b7205031cec4	07fc4598e488	7ec351c0d531	Jeroen Bakker	Version bump: 2.93.4-release	Aug 31 2021, 11:23 AM
7ec351c0d531	063c1d35f0ac	85c08c9717b1	Sebastian Parborg	FFMPEG: Fix building with older versions that need… (Show More…)	Aug 24 2021, 3:15 PM
85c08c9717b1	c392bf56278b	f53cdbdd2781	Sebastian Parborg	VSE: Flush audio encode after finishing video export (Show More…)	Jul 5 2021, 2:16 PM
f53cdbdd2781	b051e6d9e391	1a4122d4415b	Jeroen Bakker	Pipeline: Use more explicit cuda versions.	Aug 23 2021, 1:50 PM
1a4122d4415b	3fc89f3775c3	e97a2c228ef5	Sebastian Parborg	Add sanity NULL checks when loading sound sequences (Show More…)	Aug 16 2021, 4:50 PM
e97a2c228ef5	f223bf7faea5	c634d859b216	Richard Antalik	Fix T87967: M2T video seeking is broken (Show More…)	Aug 16 2021, 2:35 PM
c634d859b216	1ae127fbf460	489df7ac88ce	Sebastian Parborg	VSE: Use lines to draw waveform (Show More…)	Jul 1 2021, 6:51 PM
489df7ac88ce	80fdf610f778	00dd68405d88	Sebastian Parborg	VSE: Fix audaspace not reading ffmpeg files with start offset correctly (Show More…)	Jul 6 2021, 7:48 PM
00dd68405d88	cfa4d8f77de2	d486d2486879	Sebastian Parborg	VSE: Fix seeking issues. (Show More…)	Jul 12 2021, 7:13 PM
d486d2486879	2cac1115fd81	54a821e8fd79	Sebastian Parborg	VSE: Fix video strip duration calculation (Show More…)	Jul 12 2021, 4:00 PM
54a821e8fd79	81a5724638fe	9511009438de	Sebastian Parborg	VSE: Fix memory leak when adding bad image/movie strips (Show More…)	Jul 12 2021, 3:38 PM
9511009438de	56930c2da329	ab572f3ac1b4	Sebastian Parborg	VSE: Fix "off by one" error when encoding audio (Show More…)	Jul 9 2021, 3:06 PM
ab572f3ac1b4	b6d9e8b89895	3fa1de6ad68b	Jacques Lucke	Fix: instances are made real when they shouldn't be (Show More…)	Jul 8 2021, 1:06 PM
3fa1de6ad68b	a134fbb7c39c	f3115421828e	Philipp Oeser	Fix T90737: VSE adding nested strips could have non-unique names (Show More…)	Aug 18 2021, 12:45 PM
f3115421828e	34f2cb17c49b	9d94b358ca1d	Bastien Montagne	Fix T90719: Boost sources dowload address needed to be updated.	Aug 17 2021, 6:00 PM
9d94b358ca1d	d12e649f585d	9fb9bf59967d	Matteo F. Vescovi	Fix FTBFS on mips64el architecture (Show More…)	Aug 13 2021, 2:33 PM
9fb9bf59967d	f3491de94e4c	70df9119f46b	Ray Molenkamp	Fix: DNA struct alignment on 32 bit (Show More…)	Aug 12 2021, 12:57 AM
70df9119f46b	ba3cb0794e4e	06e3e2f21c92	Ray Molenkamp	Makesdna: Fix detecting 32 bit padding issues. (Show More…)	Aug 12 2021, 3:20 AM
06e3e2f21c92	d5720662733b	c2ba9be09810	Philipp Oeser	Fix T90364: buttons (partially) behind animchannel search block search (Show More…)	Aug 2 2021, 2:12 PM
c2ba9be09810	3874a038e2e1	60dbbaac42f5	Philipp Oeser	Fix NLA action cannot be unlinked in certain cases (Show More…)	Apr 21 2021, 6:08 PM
60dbbaac42f5	875348975a72	47618781d8d7	Philipp Oeser	Fix T88498: 'Clear Parent' does not clear parent_bone (Show More…)	Jun 4 2021, 4:39 PM
47618781d8d7	56eb8aeebca0	c2f74d62435a	Philipp Oeser	Fix T89805: NLA crash without active track (Show More…)	Jul 30 2021, 11:58 AM
c2f74d62435a	f211bc1c42e3	0cd6c1d502bc	Bastien Montagne	BLI_math: Fix several division-by-zero cases. (Show More…)	Jun 14 2021, 11:06 AM
0cd6c1d502bc	e58cd5e70089	d97e586f58ba	Germano Cavalcante	Fix T88998: GPencil not projecting to the most front surface (Show More…)	Jun 9 2021, 2:32 PM
d97e586f58ba	987ca5d89055	690fa2ba86a0	Charlie Jolly	Geometry Nodes: Fix vector math project bug (Show More…)	Jul 26 2021, 12:00 PM
690fa2ba86a0	05ac2b8f2129	7b1e8e244c76	Campbell Barton	PyAPI: resolve build error with Python 3.10 (Show More…)	Aug 9 2021, 2:55 PM
7b1e8e244c76	95bccd1f0561	06ecdab9bc6a	Campbell Barton	Fix T90493: Undo a knife-project operation crashes (Show More…)	Aug 10 2021, 6:37 AM
06ecdab9bc6a	69c0091d7b1b	85b28933f079	Campbell Barton	Fix T88033: Python reference memory leaks for non main data-blocks (Show More…)	Aug 11 2021, 8:56 AM
85b28933f079	3d013ceb821a	e1e2abd4bf0c	Campbell Barton	Fix T89241: 3D Text "Scale to Fit" wraps onto the second line (Show More…)	Aug 12 2021, 5:00 PM
e1e2abd4bf0c	6b86bf7d43a0	2cbfa786f305	Campbell Barton	Fix memory leak in edit-mesh dissolve degenerate	Aug 17 2021, 8:46 AM
2cbfa786f305	9e3015b76a2d	9eb62b99bc0a	Antonio Vazquez	Fix T89306: GPencil selection doesn't work correctly with modifiers (Show More…)	Jun 21 2021, 9:52 AM
9eb62b99bc0a	d82c9b2cf8b9	1e736d8a95b2	Campbell Barton	Fix T90791: Knife project leaks memory with curve/text cutter	Aug 20 2021, 7:19 AM
1e736d8a95b2	e7034f3dd9bb	afde98a8268d	Campbell Barton	Cleanup: rename BKE_mesh_free -> BKE_mesh_free_data (Show More…)	Aug 20 2021, 7:08 AM
afde98a8268d	01df24832c8e	20f04ce62af1	Campbell Barton	Cleanup: accidentally included printf	Aug 20 2021, 8:02 AM
20f04ce62af1	d9f6cd00b93e	63559a779c04	Campbell Barton	Fix memory leak with building springs in the cloth simulator (Show More…)	Aug 20 2021, 7:57 AM
63559a779c04	087265b5dec9	8b80d19f3641	Jeroen Bakker	Version bump: 2.93.4-rc	Aug 18 2021, 2:30 PM
8b80d19f3641	098056654e26	9fca86d5494e	Sergey Sharybin	Fix T88552: Cycles changing Render Passes in viewport does not work (Show More…)	May 26 2021, 11:16 AM
9fca86d5494e	d548d2480364	1eeae9be1531	Jeroen Bakker	Version bump: 2.93.3-release	Aug 17 2021, 3:01 PM
1eeae9be1531	df14282d61da	ee486aa5ce08	Philipp Oeser	[2.93 only] pose slide factor wrong in redo popup (Show More…)	Aug 12 2021, 4:58 PM
ee486aa5ce08	49ea6394d21a	93aae90ab573	Bastien Montagne	Fix T83164: Spline IK `joint_bindings` parameter is broken. (Show More…)	Aug 5 2021, 5:17 PM
93aae90ab573	84ff32ee3cbc	45efd0b6a154	Bastien Montagne	Cleanup/Fix RNA array length accessors returning non-zero values in invalid… (Show More…)	Aug 5 2021, 4:48 PM
45efd0b6a154	2d09bcad15e9	2ccf4b15cc03	Bastien Montagne	Fix T89835: Crash after Instancing to Scene after making linked Collection… (Show More…)	Aug 5 2021, 11:29 AM
2ccf4b15cc03	e3588bc0fcc9	6e987ca32ac2	Philipp Oeser	Fix T87041: Driver Editor not updated in realtime (Show More…)	Jul 22 2021, 11:09 PM
6e987ca32ac2	3c6513b47b29	1fa73076ca26	Philipp Oeser	Fix T78469: Output Metadata: Strip Name no longer accessible (Show More…)	Jul 30 2021, 8:34 AM
1fa73076ca26	1fd58984c251	4e14fe167dcc	Jacques Lucke	Fix T88807: crash when there are multiple links between the same sockets (Show More…)	Jun 14 2021, 10:04 AM
4e14fe167dcc	4741431efaa1	2ae04254b374	Philipp Oeser	Fix particle system duplication duplicates all systems (Show More…)	Jul 26 2021, 9:38 PM
2ae04254b374	9053a6727c81	443ae0f22dd8	Jagannadhan Ravi	Speedup rigid body "Copy from Active" operator (Show More…)	Jul 20 2021, 6:57 PM
443ae0f22dd8	4ab63b14b2fa	69edb9c7d969	Yann Lanthony	Fix T89952: GPencil channel box selection offset (Show More…)	Jul 29 2021, 10:38 AM
69edb9c7d969	95421ba5b19d	a818ad5a5498	YimingWu	LineArt: Occlusion accuracy fix. (Show More…)	Jul 27 2021, 8:02 AM
a818ad5a5498	0ad4f27335a5	bc627fbf657e	Campbell Barton	Fix memory leak with Python RNA property get callback errors (Show More…)	Jul 27 2021, 5:07 PM
bc627fbf657e	c10437bdaa4e	2be2aeaf0a51	Campbell Barton	Fix gpu.types.GPUTexture crash when the size argument was too big (Show More…)	Jul 29 2021, 6:09 AM
2be2aeaf0a51	91480d0472fd	db5501eb6edd	Campbell Barton	Fix memory leaks in Python gizmo get/set handlers	Jul 29 2021, 6:31 AM
db5501eb6edd	f26b118b5d5a	168965835c98	Campbell Barton	Revert "Fix spin-gizmo not allowing click events to select vertices" (Show More…)	Aug 3 2021, 8:06 AM
168965835c98	b8c73649725e	2bb38f302287	Campbell Barton	Fix T85436: Separate by loose parts doesn't show new objects (Show More…)	Aug 3 2021, 10:08 AM
2bb38f302287	7433f1b675db	a1b687c7a4aa	Campbell Barton	Fix T90417: font loading creates duplicate ID names (Show More…)	Aug 4 2021, 4:57 AM
a1b687c7a4aa	69804e6f99d1	f6665f506b0a	Julian Eisel	Fix broken logic in Windows directory query function (Show More…)	Aug 3 2021, 7:37 PM
f6665f506b0a	841eccfa62c6	e862874606b9	Campbell Barton	Fix T89450: Crash slicing BMEditSelSeq (Show More…)	Aug 5 2021, 8:44 AM
e862874606b9	92bac8c8951e	4d7f10d6143f	Campbell Barton	Fix slicing with negative indices (Show More…)	Aug 5 2021, 8:44 AM
4d7f10d6143f	09623c522fbb	ec00d218c9fb	Campbell Barton	Fix fix invalid index use for edit-mesh laplacian smooth (Show More…)	Aug 5 2021, 2:32 PM
ec00d218c9fb	da9191b86bed	fb7510087fdf	Germano Cavalcante	Fix T90477: Cursor vertex snapping not working in UV editor (Show More…)	Aug 6 2021, 4:44 PM
fb7510087fdf	2a9d3bae7aee	1eb06de2607a	Jeroen Bakker	Version bump: 2.93.3-rc	Aug 4 2021, 4:17 PM
1eb06de2607a	a0bccc035ac0	cb6d1b76dcb1	Jeroen Bakker	Version bump: 2.93.2 release.	Aug 3 2021, 7:58 AM
cb6d1b76dcb1	e83812a5b579	45ed762124c5	Jeroen Bakker	Remove pipeline_config.json (Show More…)	Aug 2 2021, 2:46 PM
45ed762124c5	9615b5d8467f	fdb811f03057	Brecht Van Lommel	Cycles: upgrade CUDA to 11.4 (Show More…)	Jul 26 2021, 7:45 PM
fdb811f03057	5f04ce3d35a4	256ab174d834	Brecht Van Lommel	Fix T89884: Cycles stuck on first sample in viewport render (Show More…)	May 17 2021, 6:23 PM
256ab174d834	c6116cda8f80	60a0928f3559	Jeroen Bakker	Added pipeline config formatted in yaml.	Jul 26 2021, 2:57 PM
60a0928f3559	7d2464994c01	59b77cd68848	Himanshi Kalra	Fix T85517: Cannot type Space while holding Shift key in text-field like spaces. (Show More…)	Jul 26 2021, 9:08 AM
59b77cd68848	35834ebf7ad3	05ffe05ebcd3	Yann Lanthony	Fix T89733: Py API: bpy.data.orphans_purge argument parsing (Show More…)	Jul 22 2021, 12:46 PM
05ffe05ebcd3	1f52cabeeb4d	00b135a37923	Philipp Oeser	Fix T89982: Geometry Nodes: 'New' Button tries to create node_tree on active… (Show More…)	Jul 20 2021, 1:47 PM
00b135a37923	dbd0855cfb02	283481643c56	Philipp Oeser	Fix T89981: missing refresh on the compositors render layer node when… (Show More…)	Jul 20 2021, 2:25 PM
283481643c56	9f7494d56586	3e6ea470ee73	Brecht Van Lommel	Fix T89736: Cycles error with persistent data, displacement and motion blur	Jul 12 2021, 3:56 PM
3e6ea470ee73	2c6dab40eb4b	25a1b27a93ee	Philipp Oeser	Fix T89851: Geometry nodes: wrongly detected "Node group has unidentified nodes… (Show More…)	Jul 14 2021, 11:39 AM
25a1b27a93ee	cfe4b946900f	81e12cd9b123	YimingWu	LineArt: Fix crash due to empty duplicollection.	Jun 11 2021, 11:55 AM
81e12cd9b123	e01a8b09f2e7	d070cce77881	Kévin Dietrich	Fix T89455: Cycles crash when rendering a Mesh with autosmooth (Show More…)	Jun 28 2021, 1:03 PM
d070cce77881	0aa227c5c5ab	b529a84ec386	Kévin Dietrich	Fix T88756: crash when baking with autosmooth (Show More…)	Jun 25 2021, 12:56 PM
b529a84ec386	10fdd1ba8841	2d32bf14e47e	Philipp Oeser	Fix T88015: Round end caps on Freestyle lines not shaped as documented (Show More…)	May 21 2021, 1:42 PM
2d32bf14e47e	c2278ec0be50	563fdaaa397b	Philipp Oeser	Fix T89765: boolean modifier collection refcount issue (Show More…)	Jul 10 2021, 4:15 PM
563fdaaa397b	3c25bf997280	7b94e7cca49a	Philipp Oeser	Fix channel packed images display in the Image/Node editor (Show More…)	Jul 9 2021, 4:51 PM
7b94e7cca49a	adcaaf7faea5	cb1601ddf37f	Philipp Oeser	Alembic export: evaluation mode option (Show More…)	Jul 6 2021, 10:20 AM
cb1601ddf37f	acffa5412530	5d1ef0efd017	Philipp Oeser	Alembic: remove non-functional "Renderable Objects" only option (Show More…)	Jul 5 2021, 11:27 AM
5d1ef0efd017	3fa37745ccf5	41bd164e4c77	Campbell Barton	Fix object "Set Origin" operating on linked library data (Show More…)	Jul 13 2021, 5:01 AM
41bd164e4c77	f1e0ec87b66b	062764d5d019	Campbell Barton	Fix T70356: Scaling up 1x1 pixel image reads past buffer bounds (Show More…)	Jul 16 2021, 7:41 AM
062764d5d019	9d0b5e89a092	d097d35be6df	Campbell Barton	Fix T89861: Checking face selection breaks UV stitch operator	Jul 16 2021, 9:47 AM
d097d35be6df	9500f7c73feb	9e64fd461ac3	Jesse Yurkovich	Fix T89868: Crash showing thumbnail of wide-aspect image (Show More…)	Jul 18 2021, 2:42 AM
9e64fd461ac3	89f0ebe1c6cc	2659bc54577b	Jeroen Bakker	Line Art Bug FIx: stroke default in-front should be on (Show More…)	Jul 7 2021, 7:52 AM
2659bc54577b	bc3b996b573e	aa1bbadb5b6a	Sebastian Parborg	Fix T89153: Follow Path for empty works only in negative values (Show More…)	Jun 29 2021, 5:29 PM
aa1bbadb5b6a	1e597d1d2fdc	d3f7ed08e78b	Jeroen Bakker	Fix T89571: Align Orientation to Target keeps rotation when toggled (Show More…)	Jul 7 2021, 7:41 AM
d3f7ed08e78b	6d0229207f33	e9d6f2164e4d	Jeroen Bakker	Cleanup: remove compilation warning in previous commit.	Jun 30 2021, 9:45 AM
e9d6f2164e4d	946ea7c02056	bec8e436a1cd	YimingWu	UI: Hide collection tab when scene master collection is active (Show More…)	Jun 28 2021, 9:46 AM
bec8e436a1cd	c019508bd4c6	444a8cbc2fd9	Sebastian Parborg	Fix: VSE seeking with proxy strips would fail on certain frames (Show More…)	Jun 14 2021, 7:05 PM
444a8cbc2fd9	07b3ee47f2cc	7616f4ae5773	Sebastian Parborg	Fix: VSE search in mpegts files would fail (Show More…)	Jun 10 2021, 2:38 AM
7616f4ae5773	5a26bf796b71	a68f5456e48b	Sebastian Parborg	Fix: VSE indexer seeking not working correctly (Show More…)	Jun 9 2021, 9:03 PM
a68f5456e48b	d1c4fc1ee4ed	cea80f1add58	Sebastian Parborg	Fix: VSE timecodes being used even when turned off. (Show More…)	Jun 9 2021, 1:56 PM
cea80f1add58	c6e7ebf61714	02a6be544324	Sebastian Parborg	Fix: Prevent small memory leak in VSE indexer (Show More…)	Jun 8 2021, 11:17 PM
02a6be544324	6320bffce3a9	7eb3e77b94f5	Sebastian Parborg	Fix: Wrong logic for checking if we can reuse decoded frame (Show More…)	Jun 7 2021, 6:12 PM
7eb3e77b94f5	03ba0461fd23	13ab6b7bb60c	Sebastian Parborg	FFmpeg: Fix seeking not returning the correct frame when not using TC index (Show More…)	Jun 5 2021, 2:47 AM
13ab6b7bb60c	e90ad66eeb5b	00ffe028200a	Richard Antalik	Fix T57397: Movies are blurred after sws_scale (Show More…)	Jun 2 2021, 9:29 PM
00ffe028200a	c7c18b072ee3	19c0666d408a	Richard Antalik	FFmpeg: Update proxy settings (Show More…)	Jun 2 2021, 9:25 PM
19c0666d408a	6e54a9162dbe	14308b0a5ef0	Sebastian Parborg	Fix T88623, T87044: Make encoded videos play correctly in VLC (Show More…)	May 31 2021, 11:25 AM
14308b0a5ef0	77889e62b585	fe4cbe62dff2	Sebastian Parborg	Make encoded video fps correct with ffmpeg < 4.4 (Show More…)	May 28 2021, 6:37 PM
fe4cbe62dff2	fee78c57937f	f522e8db2288	Sebastian Parborg	Fix T87932: Failure to build movie strip proxy (Show More…)	May 28 2021, 6:35 PM
f522e8db2288	2fbefb55c582	3b7a520d8861	Sebastian Parborg	Cleanup: Remove deprecated variables and functions calls from our ffmpeg code (Show More…)	May 7 2021, 5:10 PM
3b7a520d8861	76ed277b1a40	2c7efe5ac055	Jeroen Bakker	Fixed issue in previous commit. (Show More…)	Jun 29 2021, 9:08 AM
2c7efe5ac055	60e674c9943b	3c6a981fd986	Jeroen Bakker	Fix T89405: Viewport Render Preview glitching (AMD) (Show More…)	Jun 29 2021, 8:23 AM
3c6a981fd986	2776c0183e45	46daaec425a1	Jeroen Bakker	Fix: Crash Requesting GPU_SHADER_GPENCIL_FILL builtin shader. (Show More…)	Jun 28 2021, 8:51 AM
46daaec425a1	7f67daeafa2a	7573e4510346	Pratik Borhade	Fix T88808: Set Origin missing from Text object in 2.93 (Show More…)	Jun 23 2021, 11:08 AM
7573e4510346	b8ee7e589ae3	129798cacbd9	Jeroen Bakker	Fix T89004: Undefined Geometry nodes cause a crash when connected to a Group… (Show More…)	Jun 30 2021, 9:22 AM
129798cacbd9	3d6afc996cfc	32658bb5c9fa	Fen	Fix T89247: Dereference arguments to comparison function correctly (Show More…)	Jun 18 2021, 3:13 AM
32658bb5c9fa	f79164346fd4	174f39bd0393	Campbell Barton	Fix invalid polygon normal array access building bake data (Show More…)	Jun 18 2021, 9:36 AM
174f39bd0393	1f1f1cbaeeb1	27e326526793	Falk David	Fix T89265: Crash when tabbing through num inputs (Show More…)	Jun 23 2021, 6:56 AM
27e326526793	ef7356fd607b	cf9cacd091e8	Piotr Makal	Fix edit-mesh random select regression in random seed use (Show More…)	Jun 28 2021, 11:54 AM
cf9cacd091e8	9e205ca1173f	03d5c8b4edf4	Campbell Barton	Fix T89526: "Toggle Maximize Area" clears context screen properties (Show More…)	Jun 29 2021, 12:50 PM
03d5c8b4edf4	db12c55cb98c	1b8d33b18c2f	Jeroen Bakker	Blender v2.93.2 candidate version bump.	Jun 23 2021, 2:44 PM
1b8d33b18c2f	29b814adef43	baa7a5397486	Jeroen Bakker	Blender v2.93.1 release version bump.	Jun 22 2021, 7:57 AM
baa7a5397486	46f8746244e0	b4a81d805374	Jeroen Bakker	Fix T86956: VSE shading mode ignores Grease Pencil Vertex colors. (Show More…)	May 25 2021, 3:10 PM
b4a81d805374	9902974d2b07	b61f4fd8da3a	Campbell Barton	Fix outdated face tessellation use when editing edit-mesh coodinates	Jun 15 2021, 5:28 AM
b61f4fd8da3a	77e2308109d4	bc648018571d	Campbell Barton	Fix image space missing mask display panel	Jun 15 2021, 2:50 AM
bc648018571d	cd57a655ad09	ba7f11075354	Campbell Barton	Fix modifier deform by armature check ignoring virtual modifiers (Show More…)	Jun 13 2021, 6:46 AM
ba7f11075354	50ed0893f1eb	e24765d7d3a1	Campbell Barton	Docs: remove deprecated parameter from bmesh docs (Show More…)	Jun 10 2021, 1:32 PM
e24765d7d3a1	2ce71747c9fb	573011217479	YimingWu	LineArt: Camera marker update fix. (Show More…)	Jun 9 2021, 6:14 PM
573011217479	f804e15a4691	d354e6a84688	YimingWu	LineArt: Fix edge clipping index error. (Show More…)	Jun 6 2021, 5:18 AM
d354e6a84688	0452e4295ab9	706c7d775d26	Philipp Oeser	Texture Paint: changing paint slots and viewport could go out of sync (Show More…)	Jun 4 2021, 4:00 PM
706c7d775d26	16bf49fb1f8c	db909281f281	Germano Cavalcante	Fix T77651: Black screen on Blender startup on ChromeOS (Show More…)	Jun 7 2021, 8:11 PM
db909281f281	951b29ab93ea	e1d2485fd32b	Ray Molenkamp	Fix T88813: Scalable allocator not used on win10 (Show More…)	Jun 5 2021, 1:22 AM
e1d2485fd32b	deb979f074b5	0b577e977b43	Jeroen Bakker	EEVEE: AOVs not same as cycles. (Show More…)	Jun 2 2021, 4:58 PM
0b577e977b43	3e5a1b86f4c3	5a612097abb4	Jeroen Bakker	Fix T88567: Cryptomatte only works for the first View Layer. (Show More…)	Jun 2 2021, 10:05 AM
5a612097abb4	9397963b2b58	dbb002387d12	Jeroen Bakker	Fix T88666: Cryptomatte: EXR sequence does not update when scrubbing the… (Show More…)	May 31 2021, 2:32 PM
dbb002387d12	f936fdfc63f5	c1d67abcd8f0	Philipp Oeser	Fix T88625: Multiobject UV hiding/unhiding does not work with UV_SYNC_SELECTION (Show More…)	May 27 2021, 3:30 PM
c1d67abcd8f0	4159917aaa02	b38eb3105096	Philipp Oeser	Fix T88531: Mantaflow problem with geometry nodes (Show More…)	May 25 2021, 4:34 PM
b38eb3105096	1f303cacb3c5	8eef2f83e9aa	Philipp Oeser	Fix T88566: Mantaflow inflow with shapekeys is not working anymore (regression) (Show More…)	May 25 2021, 4:27 PM
8eef2f83e9aa	9a6a20ce05c5	cc5392b4d93d	Campbell Barton	Fix T88111: Skin modifier assets within invalid face normals (Show More…)	May 26 2021, 8:06 AM
cc5392b4d93d	70a4c2060131	9d134104e476	Campbell Barton	Fix buffer overrun in paint_line_strokes_spacing (Show More…)	Jun 1 2021, 4:49 AM
9d134104e476	d86022e9db3e	7edbe463d2d9	Campbell Barton	Fix T88899: `__file__` not set for `text.as_module()`	Jun 7 2021, 6:04 AM
7edbe463d2d9	c78ea9da907a	ddb2d7143899	Jeroen Bakker	Versionbump: 2.93.1 candidate.	Jun 2 2021, 5:10 PM
ddb2d7143899	b31477052f29	84da05a8b806	Dalai Felinto	Fix typo in Linux appdata	Jun 2 2021, 3:05 PM
84da05a8b806	53d0522cba95	383bc8d9bc06	Dalai Felinto	Docs: 2.93 release description for Linux appdata	Jun 2 2021, 1:21 PM
383bc8d9bc06	8a5386f0a810	46a14bd6a317	Jeroen Bakker	Blender version bump 2.93 release.	Jun 1 2021, 4:46 PM

Feature: display_stack() function for meta_toggleClosedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 42395

build_files/build_environment/install_deps.sh

build_files/cmake/platform/platform_win32_bundle_crt.cmake

build_files/config/pipeline_config.json

build_files/config/pipeline_config.yaml

extern/audaspace/bindings/C/AUD_Special.cpp

extern/audaspace/bindings/C/AUD_Types.h

extern/audaspace/include/IReader.h

extern/audaspace/include/fx/VolumeReader.h

extern/audaspace/plugins/ffmpeg/FFMPEGReader.h

extern/audaspace/plugins/ffmpeg/FFMPEGReader.cpp

extern/audaspace/src/fx/VolumeReader.cpp

intern/cycles/blender/blender_object.cpp

intern/cycles/blender/blender_sync.h

intern/cycles/blender/blender_sync.cpp

intern/cycles/device/cuda/device_cuda_impl.cpp

intern/cycles/kernel/CMakeLists.txt

intern/ffmpeg/ffmpeg_compat.h

release/freedesktop/org.blender.Blender.appdata.xml

release/scripts/freestyle/modules/freestyle/shaders.py

release/scripts/modules/bpy_types.py

release/scripts/startup/bl_operators/geometry_nodes.py

release/scripts/startup/bl_operators/rigidbody.py

release/scripts/startup/bl_ui/properties_collection.py

release/scripts/startup/bl_ui/properties_output.py

release/scripts/startup/bl_ui/space_image.py

release/scripts/startup/bl_ui/space_sequencer.py

release/scripts/startup/bl_ui/space_view3d.py

source/blender/blenfont/intern/blf_glyph.c

source/blender/blenkernel/BKE_blender_version.h

source/blender/blenkernel/BKE_customdata.h

source/blender/blenkernel/BKE_lib_id.h

source/blender/blenkernel/BKE_mesh.h

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/BKE_sound.h

source/blender/blenkernel/CMakeLists.txt

source/blender/blenkernel/intern/anim_sys.c

source/blender/blenkernel/intern/cloth.c

source/blender/blenkernel/intern/constraint.c

source/blender/blenkernel/intern/customdata.c

source/blender/blenkernel/intern/fluid.c

source/blender/blenkernel/intern/font.c

source/blender/blenkernel/intern/gpencil.c

source/blender/blenkernel/intern/lib_id.c

source/blender/blenkernel/intern/lib_id_delete.c

source/blender/blenkernel/intern/material.c

source/blender/blenkernel/intern/mesh.c

source/blender/blenkernel/intern/modifier.c

source/blender/blenkernel/intern/node.cc

source/blender/blenkernel/intern/particle_system.c

source/blender/blenkernel/intern/scene.c

source/blender/blenkernel/intern/sound.c

source/blender/blenkernel/intern/writeffmpeg.c

source/blender/blenlib/BLI_math_vector.h

source/blender/blenlib/intern/math_geom.c

source/blender/blenlib/intern/math_vector.c

source/blender/blenlib/intern/math_vector_inline.c

source/blender/blenlib/intern/storage.c

source/blender/blenloader/intern/versioning_290.c

source/blender/bmesh/operators/bmo_smooth_laplacian.c

source/blender/bmesh/tools/bmesh_region_match.c

source/blender/compositor/nodes/COM_CryptomatteNode.cc

source/blender/draw/engines/eevee/eevee_renderpasses.c

source/blender/draw/engines/gpencil/gpencil_engine.h

source/blender/draw/engines/image/image_engine.c

source/blender/draw/intern/draw_manager_texture.c

source/blender/editors/animation/anim_channels_edit.c

source/blender/editors/animation/time_scrub_ui.c

source/blender/editors/armature/pose_slide.c

source/blender/editors/gpencil/gpencil_select.c

source/blender/editors/gpencil/gpencil_utils.c

source/blender/editors/interface/interface_eyedropper_color.c

source/blender/editors/interface/interface_handlers.c

source/blender/editors/io/io_alembic.c

Feature: display_stack() function for meta_toggle
ClosedPublic
Actions

Revision Contents
Changeset List