Page MenuHome
Differential D12049

Line Art feature update: Camera Overscan
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on Jul 28 2021, 11:05 AM.

Details

Reviewers
Antonio Vazquez (antoniov)
Group Reviewers
User Interface
Grease Pencil
Maniphest Tasks
T87739: Line Art further improvement list
Commits
rB8e9d06f5a042: LineArt: Camera Overscan
Summary

Expand camera effective region to a portion beyond image frame so strokes won't end right at the border.

Needs D12047

Diff Detail

Repository
rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.Jul 28 2021, 11:05 AM
YimingWu (NicksBest) created this revision.
YimingWu (NicksBest) updated this revision to Diff 40041.Jul 28 2021, 11:12 AM
YimingWu (NicksBest) edited the summary of this revision. (Show Details)
YimingWu (NicksBest) added a parent revision: D12047: Line Art feature update: Custom Camera.
YimingWu (NicksBest) added a task: T87739: Line Art further improvement list.
Antonio Vazquez (antoniov) accepted this revision.Jul 28 2021, 1:20 PM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).

LGTM, just some comments above.

This parameter is very handy.

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
2074

Maybe you could use const here

2084

Not sure if this type of code must be included in master

This revision is now accepted and ready to land.Jul 28 2021, 1:20 PM
YimingWu (NicksBest) marked 2 inline comments as done.Jul 28 2021, 1:34 PM
YimingWu (NicksBest) added inline comments.
source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
2084

It's been there for some time 🤔 users sometimes can also use this info to report stuff so yeah.

YimingWu (NicksBest) updated this revision to Diff 40052.Jul 28 2021, 1:51 PM
YimingWu (NicksBest) marked an inline comment as done.

Fix visibility check for supporting camera shift values.

Closed by commit rB8e9d06f5a042: LineArt: Camera Overscan (authored by YimingWu (NicksBest)). · Explain WhyJul 28 2021, 1:57 PM
This revision was automatically updated to reflect the committed changes.
YimingWu (NicksBest) added a commit: rB8e9d06f5a042: LineArt: Camera Overscan.
Daniel Salazar (zanqdo) added a subscriber: Daniel Salazar (zanqdo).Aug 2 2021, 11:14 PM

When a new feature already exists in another context, it is useful to check how the UI is done already. For example Eevee has an overscan feature and the UI looks like this

So it is displayed in percentage and has a separate check for enabling and disabling the overscan

YimingWu (NicksBest) added a comment.Aug 3 2021, 1:48 AM

Thanks for the reminder :D. I'll make it more consistent.

Revision Contents
Changeset List

PathSize
source/
blender/
gpencil_modifiers/
intern/
2 lines
lineart/
2 lines
18 lines
makesdna/
1 line
8 lines
makesrna/
intern/
9 lines

Diff 40041

View Options

source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/MOD_lineart.h

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

Loading...
View Options

source/blender/makesdna/DNA_gpencil_modifier_defaults.h

Loading...
View Options

source/blender/makesdna/DNA_gpencil_modifier_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_gpencil_modifier.c

Loading...