Page MenuHome

Line Art feature update: Smooth tolerance value for chaining.
ClosedPublic

Authored by YimingWu (NicksBest) on Jul 28 2021, 11:36 AM.

Details

Summary

This will smooth out jaggy lines with a given threshold. For each point in a stroke, the ones with in a given distance of its previous segment will be removed, thus "zig-zag" artefacts can be removed.

See GIF for example:

Diff Detail

Repository
rB Blender

Event Timeline

Updated to include ui range changes.

Antonio Vazquez (antoniov) requested changes to this revision.Sep 11 2021, 10:46 AM

It looks right but set as need changes while you review the comments above.

source/blender/gpencil_modifiers/intern/lineart/lineart_chain.c
931

Maybe you can use LISTBASE_FOREACH_MUTABLE

source/blender/makesdna/DNA_gpencil_modifier_types.h
991–995

Missing . at the end of comments.

source/blender/makesrna/intern/rna_gpencil_modifier.c
3163

Why don't add now the define in DNA header and avoid hard code value and remove comment for future change?

This revision now requires changes to proceed.Sep 11 2021, 10:46 AM
YimingWu (NicksBest) marked 3 inline comments as done.

Updated to latest master

source/blender/gpencil_modifiers/intern/lineart/lineart_chain.c
931

I changed the logic here after an update.

Also: Is this patch a go now? 🤔

Antonio Vazquez (antoniov) accepted this revision.EditedSep 25 2021, 10:34 AM

For UI, not sure if we need approval from Hans or Pablo

This revision is now accepted and ready to land.Sep 25 2021, 10:34 AM

Updated to latest master