Page MenuHome
Differential D12050

Line Art feature update: Smooth tolerance value for chaining.
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on Jul 28 2021, 11:36 AM.

Details

Reviewers
Antonio Vazquez (antoniov)
Group Reviewers
User Interface
Grease Pencil
Maniphest Tasks
T87739: Line Art further improvement list
Commits
rB80f7bc6d8e7e: LineArt: Smooth tolerance value for chaining.
Summary

This will smooth out jaggy lines with a given threshold. For each point in a stroke, the ones with in a given distance of its previous segment will be removed, thus "zig-zag" artefacts can be removed.

See GIF for example:

Diff Detail

Event Timeline

YimingWu (NicksBest) requested review of this revision.Jul 28 2021, 11:36 AM
YimingWu (NicksBest) created this revision.
YimingWu (NicksBest) added a task: T87739: Line Art further improvement list.
YimingWu (NicksBest) updated this revision to Diff 40266.Aug 3 2021, 2:30 PM

Updated to include ui range changes.

Antonio Vazquez (antoniov) requested changes to this revision.Sep 11 2021, 10:46 AM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).

It looks right but set as need changes while you review the comments above.

source/blender/gpencil_modifiers/intern/lineart/lineart_chain.c
931

Maybe you can use LISTBASE_FOREACH_MUTABLE

source/blender/makesdna/DNA_gpencil_modifier_types.h
991

Missing . at the end of comments.

source/blender/makesrna/intern/rna_gpencil_modifier.c
3163

Why don't add now the define in DNA header and avoid hard code value and remove comment for future change?

This revision now requires changes to proceed.Sep 11 2021, 10:46 AM
YimingWu (NicksBest) updated this revision to Diff 41700.Sep 11 2021, 1:09 PM
YimingWu (NicksBest) marked 3 inline comments as done.

Updated to latest master

source/blender/gpencil_modifiers/intern/lineart/lineart_chain.c
931

I changed the logic here after an update.

Antonio Vazquez (antoniov) accepted this revision as: Antonio Vazquez (antoniov).Sep 20 2021, 6:32 PM
Antonio Vazquez (antoniov) added a subscriber: Matias Mendiola (mendio).

@Matias Mendiola (mendio) any UI comment?

Matias Mendiola (mendio) added a comment.Sep 20 2021, 6:57 PM
In D12050#327905, @Antonio Vazquez (antoniov) wrote:

@Matias Mendiola (mendio) any UI comment?

It's ok for me

YimingWu (NicksBest) added a comment.Sep 25 2021, 7:45 AM

Also: Is this patch a go now? 🤔

Antonio Vazquez (antoniov) accepted this revision.EditedSep 25 2021, 10:34 AM

For UI, not sure if we need approval from Hans or Pablo

This revision is now accepted and ready to land.Sep 25 2021, 10:34 AM
YimingWu (NicksBest) updated this revision to Diff 42441.Sep 26 2021, 1:41 PM

Updated to latest master

Closed by commit rB80f7bc6d8e7e: LineArt: Smooth tolerance value for chaining. (authored by YimingWu (NicksBest)). · Explain WhySep 26 2021, 1:43 PM
This revision was automatically updated to reflect the committed changes.
YimingWu (NicksBest) added a commit: rB80f7bc6d8e7e: LineArt: Smooth tolerance value for chaining..
Vyacheslav (hitrpr) awarded a token.Sep 29 2021, 8:02 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
9 lines
gpencil_modifiers/
intern/
1 line
lineart/
3 lines
28 lines
10 lines
makesdna/
2 lines
6 lines
2 lines
makesrna/
intern/
9 lines

Diff 42441

View Options

source/blender/blenloader/intern/versioning_300.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/MOD_lineart.h

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_chain.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

Loading...
View Options

source/blender/makesdna/DNA_gpencil_modifier_defaults.h

Loading...
View Options

source/blender/makesdna/DNA_gpencil_modifier_types.h

Loading...
View Options

source/blender/makesdna/DNA_gpencil_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_gpencil_modifier.c

Loading...