Page MenuHome
Differential D12051

Line Art feature update: Automatic crease with flat/smooth surfaces
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on Jul 28 2021, 11:56 AM.

Details

Reviewers
Sebastian Parborg (zeddb)
Antonio Vazquez (antoniov)
Group Reviewers
Grease Pencil
User Interface
Maniphest Tasks
T87739: Line Art further improvement list
Commits
rBc1cf66bff3c0: LineArt: Automatic crease with flat/smooth faces.
Summary

This allows crease lines to be automatically hidden on smooth surfaces, also provided options for:

  • Showing crease on marked sharp edges.
  • Force crease detection on smooth surfaces.

Diff Detail

Repository
rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.Jul 28 2021, 11:56 AM
YimingWu (NicksBest) updated this revision to Diff 40045.
YimingWu (NicksBest) created this revision.
YimingWu (NicksBest) edited the summary of this revision. (Show Details)

Fix naming problem

YimingWu (NicksBest) added a task: T87739: Line Art further improvement list.Jul 28 2021, 11:58 AM
YimingWu (NicksBest) edited the summary of this revision. (Show Details)Jul 28 2021, 12:06 PM
YimingWu (NicksBest) updated this revision to Diff 40177.EditedJul 31 2021, 5:42 AM

Mesh auto smooth supported.

Crease value priority:

  • Highest: object line art crease override.
  • Second: auto smooth crease.
  • Lowest: line art modifier crease.
Antonio Vazquez (antoniov) added a reviewer: Sebastian Parborg (zeddb).Jul 31 2021, 9:55 AM
Antonio Vazquez (antoniov) accepted this revision.Sep 11 2021, 10:53 AM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).

LGTM... Not sure about maths (I don't know enough about LineArt to test )...we need someone with good LineArt knowledge.

This revision is now accepted and ready to land.Sep 11 2021, 10:53 AM
YimingWu (NicksBest) updated this revision to Diff 41697.Sep 11 2021, 12:54 PM

Updated to latest master

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Sep 14 2021, 5:29 PM

I'm curious, is there a reason for this to be optional? Modifying the input meshes seems like a valid thing to do in this case, instead of adding yet another option to the modifier.

source/blender/makesdna/DNA_lineart_types.h
54–59

Looks like there are two defines with the same value now.

YimingWu (NicksBest) added a comment.Sep 15 2021, 7:44 AM
In D12051#325600, @Hans Goudey (HooglyBoogly) wrote:

I'm curious, is there a reason for this to be optional? Modifying the input meshes seems like a valid thing to do in this case, instead of adding yet another option to the modifier.

Because sometimes you need to have sharp shading at some places while not showing crease, and vise versa.

Closed by commit rBc1cf66bff3c0: LineArt: Automatic crease with flat/smooth faces. (authored by YimingWu (NicksBest)). · Explain WhySep 15 2021, 8:05 AM
This revision was automatically updated to reflect the committed changes.
YimingWu (NicksBest) added a commit: rBc1cf66bff3c0: LineArt: Automatic crease with flat/smooth faces..

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
15 lines
gpencil_modifiers/
intern/
2 lines
lineart/
3 lines
42 lines
makesdna/
2 lines
8 lines
makesrna/
intern/
12 lines

Diff 40177

View Options

source/blender/blenloader/intern/versioning_300.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/MOD_lineart.h

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

Loading...
View Options

source/blender/makesdna/DNA_gpencil_modifier_defaults.h

Loading...
View Options

source/blender/makesdna/DNA_lineart_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_gpencil_modifier.c

Loading...