Differential D12057

Asset Browser: Adjust header pulldowns to be Asset Browser specific
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on Jul 28 2021, 3:24 PM.

Details

Reviewers

Jeroen Bakker (jbakker)

Group Reviewers

Asset Browser

Maniphest Tasks

T90297: Remove Inapplicable Menus, Popups & Options

Commits

rBd8bf332f86b3: Asset Browser: Adjust header pulldowns to be Asset Browser specific

Summary

So far the Asset Browser just showed the same menus as the File Browser.
Not all of their entries made sense for the Asset Browser though. I
decided to just give them entirely different classes to avoid confusing
if-else checks everywhere. I think the code duplication this adds is a
minor issue, it's better to keep things seperated clearly IMO.

View menu: Add "Asset Details" toggle for the sidebar region.
View menu: Remove recursion sub-menu
View menu: Remove "File Path" region toggle, which doesn't apply for the Asset Browser.

Diff Detail

Repository

rB Blender

Branch

temp-asset-browser-menus-cleanup (branched from master)

Build Status

Buildable 16091
Build 16091: arc lint + arc unit

Event Timeline

Julian Eisel (Severin) requested review of this revision.Jul 28 2021, 3:24 PM

Julian Eisel (Severin) created this revision.

Harbormaster completed remote builds in B16089: Diff 40061.Jul 28 2021, 3:24 PM

Agree on this granularity adding new classes makes sense.

release/scripts/startup/bl_ui/space_filebrowser.py
491	Perhaps move closer to the asset menus to reduce searching.

Minor cleanup: Move class around, remove section heading

Harbormaster completed remote builds in B16091: Diff 40067.Jul 28 2021, 3:56 PM

Julian Eisel (Severin) marked an inline comment as done.Jul 28 2021, 3:56 PM

Julian Eisel (Severin) mentioned this in D12059: Asset Browser: Don't show inapplicable filter and display settings.Jul 28 2021, 4:45 PM

Julian Eisel (Severin) mentioned this in D12061: Asset Browser: Adjust header pulldowns to be Asset Browser specific.Jul 28 2021, 5:56 PM

Julian Eisel (Severin) mentioned this in D12062: Asset Browser: Proper context menu for assets.Jul 28 2021, 5:58 PM

Julian Eisel (Severin) added a project: Asset Browser.Jul 29 2021, 11:15 AM

Julian Eisel (Severin) added a task: T90297: Remove Inapplicable Menus, Popups & Options.Jul 29 2021, 3:34 PM

Julian Eisel (Severin) mentioned this in T82680: UI Cleanup.Jul 30 2021, 8:21 PM

Jeroen Bakker (jbakker) added inline comments.Aug 2 2021, 11:26 AM

release/scripts/startup/bl_ui/space_filebrowser.py
585	Is an inline import really needed? Would prefer header only imports.

Julian Eisel (Severin) added inline comments.Aug 2 2021, 11:33 AM

release/scripts/startup/bl_ui/space_filebrowser.py
585	To my knowledge these inline imports are preferred since they are then not executed at startup/registration time, but only when actually calling the function.