Page MenuHome
Differential D12059

Asset Browser: Don't show inapplicable filter and display settings
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on Jul 28 2021, 4:45 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Group Reviewers
Asset Browser
Maniphest Tasks
T90297: Remove Inapplicable Menus, Popups & Options
Commits
rBceb049133c6f: Asset Browser: Don't show inapplicable filter and display settings
Summary

So far the Asset Browser just showed the same popups and settings as the
File Browser. Not all of them made sense for the Asset Browser though.

  • Don't show inapplicable recursion toggle.
  • Don't show sorting options, which don't work with assets anyway.
  • Don't show the Filter popover, there are currently no applicable items in there.

Just like in D12057, I decided to add separate classes for the Asset
Browser case.

Diff Detail

Repository
rB Blender
Branch
temp-asset-browser-popups-cleanup (branched from master)
Build Status
Buildable 16094
Build 16094: arc lint + arc unit

Event Timeline

Julian Eisel (Severin) requested review of this revision.Jul 28 2021, 4:45 PM
Julian Eisel (Severin) created this revision.
Harbormaster completed remote builds in B16094: Diff 40071.Jul 28 2021, 4:45 PM
Julian Eisel (Severin) mentioned this in D12061: Asset Browser: Adjust header pulldowns to be Asset Browser specific.Jul 28 2021, 5:56 PM
Julian Eisel (Severin) mentioned this in D12062: Asset Browser: Proper context menu for assets.Jul 28 2021, 5:58 PM
Julian Eisel (Severin) added a project: Asset Browser.Jul 29 2021, 11:16 AM
Julian Eisel (Severin) added a task: T90297: Remove Inapplicable Menus, Popups & Options.Jul 29 2021, 3:34 PM
Julian Eisel (Severin) mentioned this in T82680: UI Cleanup.Jul 30 2021, 8:21 PM
Jeroen Bakker (jbakker) accepted this revision as: Jeroen Bakker (jbakker).Aug 2 2021, 11:22 AM
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).
Jeroen Bakker (jbakker) added inline comments.
release/scripts/startup/bl_ui/space_filebrowser.py
107

It is copy paste, but would not mention the comment anymore.

This revision is now accepted and ready to land.Aug 2 2021, 11:22 AM
Closed by commit rBceb049133c6f: Asset Browser: Don't show inapplicable filter and display settings (authored by Julian Eisel (Severin)). · Explain WhyAug 2 2021, 5:02 PM
This revision was automatically updated to reflect the committed changes.
Julian Eisel (Severin) added a commit: rBceb049133c6f: Asset Browser: Don't show inapplicable filter and display settings.
Julian Eisel (Severin) mentioned this in rB3ff5d8f719f5: Asset Browser: Proper context menu for assets.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
59 lines

Diff 40071

View Options

release/scripts/startup/bl_ui/space_filebrowser.py

Loading...