Page MenuHome
Differential D12091

Compositor: Full frame output nodes
ClosedPublic
Actions

Authored by Manuel Castilla (manzanilla) on Jul 30 2021, 9:59 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Commits
rBeb03529ab950: Compositor: Full frame output nodes
Summary

Adds full frame implementation to "Composite", "File Output" and
"Split Viewer" nodes.
The other nodes in "Output" submenu are implemented separately.
No functional changes.

Note:
These nodes are very similar to already reviewed nodes. The patch
is meant for a quick look before committing.

Diff Detail

Repository
rB Blender
Branch
cmp-nodes-output (branched from master)
Build Status
Buildable 16178
Build 16178: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Jul 30 2021, 9:59 PM
Manuel Castilla (manzanilla) created this revision.
Harbormaster completed remote builds in B16138: Diff 40168.Jul 30 2021, 9:59 PM
Manuel Castilla (manzanilla) edited the summary of this revision. (Show Details)Jul 30 2021, 10:03 PM
Manuel Castilla (manzanilla) added a reviewer: Jeroen Bakker (jbakker).
Manuel Castilla (manzanilla) added a project: Compositing.
Manuel Castilla (manzanilla) mentioned this in T88150: Full Frame Compositor.Jul 30 2021, 11:49 PM
Jeroen Bakker (jbakker) requested changes to this revision.Aug 2 2021, 9:12 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/compositor/operations/COM_SplitOperation.cc
88

We could hide this in its own function. COM_data_type_bytes_len

This revision now requires changes to proceed.Aug 2 2021, 9:12 AM
Manuel Castilla (manzanilla) updated this revision to Diff 40235.Aug 2 2021, 8:24 PM
  • Create COM_data_type_bytes_len function and use it
Harbormaster completed remote builds in B16178: Diff 40235.Aug 2 2021, 8:24 PM
Manuel Castilla (manzanilla) marked an inline comment as done.Aug 2 2021, 8:24 PM
Jeroen Bakker (jbakker) accepted this revision.Aug 3 2021, 8:15 AM
This revision is now accepted and ready to land.Aug 3 2021, 8:15 AM
Closed by commit rBeb03529ab950: Compositor: Full frame output nodes (authored by Manuel Castilla (manzanilla)). · Explain WhyAug 10 2021, 4:27 PM
This revision was automatically updated to reflect the committed changes.
Manuel Castilla (manzanilla) added a commit: rBeb03529ab950: Compositor: Full frame output nodes.

Revision Contents
Changeset List

Diff 40235

View Options

source/blender/compositor/COM_defines.h

Loading...
View Options

source/blender/compositor/operations/COM_CompositorOperation.h

Loading...
View Options

source/blender/compositor/operations/COM_CompositorOperation.cc

Loading...
View Options

source/blender/compositor/operations/COM_OutputFileOperation.h

Loading...
View Options

source/blender/compositor/operations/COM_OutputFileOperation.cc

Loading...
View Options

source/blender/compositor/operations/COM_SplitOperation.h

Loading...
View Options

source/blender/compositor/operations/COM_SplitOperation.cc

Loading...