Page MenuHome

Cycles-X: Turn off "CleanAux" when turning off prefiltering to avoid some artifacts.
AbandonedPublic

Authored by Alaska (Alaska) on Jul 31 2021, 1:02 PM.

Details

Reviewers
None
Summary

I have created a new differential that actually exposes the "CleanAux" setting in the user interface. D12099: Cycles-X: Expose "CleanAux" setting in the UI

In a recent commit that made changes to Cycles-X to accommodate new features from OIDN 1.4.X, the "CleanAux" setting was enabled for all use cases. This has lead to some confusion in some users and can lead to some artifacts when "Prefiltering" is turned off, which a user may wish to do for performance reasons.

I would love to create a diff that makes "CleanAux" and "Prefiltering" separate options, but I'm not well versed in programming so this is the best I can do (looking at someone else's code (https://developer.blender.org/D12043?vs=40066&id=40129), copying it, compiling to make sure it doesn't break anything, testing it, then publishing).

Diff Detail

Repository
rB Blender

Event Timeline

Alaska (Alaska) requested review of this revision.Jul 31 2021, 1:02 PM
Alaska (Alaska) abandoned this revision.
Alaska (Alaska) created this revision.
Alaska (Alaska) edited the summary of this revision. (Show Details)Jul 31 2021, 1:05 PM
Alaska (Alaska) edited the summary of this revision. (Show Details)EditedAug 1 2021, 5:50 AM

I have created a new differential that actually exposes the "CleanAux" setting in the user interface. D12099: Cycles-X: Expose "CleanAux" setting in the UI

Alaska (Alaska) edited the summary of this revision. (Show Details)Aug 1 2021, 5:50 AM