Page MenuHome

Compositor: Full frame convert nodes
ClosedPublic

Authored by Manuel Castilla (manzanilla) on Jul 31 2021, 5:34 PM.

Details

Summary

Adds full frame implementation to all nodes in "Convert" sub-menu
except "ID Mask" which is implemented separately.
No functional changes.


Note:
These nodes are very similar to already reviewed nodes. The patch
is meant for a quick look before committing.

Diff Detail

Repository
rB Blender
Branch
cmp-nodes-converter (branched from master)
Build Status
Buildable 16146
Build 16146: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Jul 31 2021, 5:34 PM
Manuel Castilla (manzanilla) created this revision.
  • restore removed "include" by mistake
Manuel Castilla (manzanilla) retitled this revision from Compositor: Full frame convert operations to Compositor: Full frame convert nodes.Jul 31 2021, 5:58 PM
Jeroen Bakker (jbakker) requested changes to this revision.Aug 2 2021, 9:00 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/compositor/operations/COM_ConvertOperation.cc
556

Not for now, but we should check if we want to support operators having multiple outputs.

source/blender/compositor/operations/COM_MathBaseOperation.cc
85

Better to do the clamping inside the update_memory_buffer_partial(it)
no need to iterate twice over the same data when the operators are small.
It makes sense when the operator itself are bigger.

Math operators branch are predictable and clamping is a predictable branch.

For convenience you could add a header only method that does the clamping (float clamp_when_enabled(float))

This revision now requires changes to proceed.Aug 2 2021, 9:00 AM
  • Do clamp in each operation iteration, iterating only once
Manuel Castilla (manzanilla) marked an inline comment as done.Aug 2 2021, 8:12 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/compositor/operations/COM_MathBaseOperation.h
56

add newline between methods.

This revision is now accepted and ready to land.Aug 3 2021, 8:14 AM
This revision was automatically updated to reflect the committed changes.