Page MenuHome

Cleanup: Remove unused/unecessary OpenVDB C API
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Jul 31 2021, 8:16 PM.

Details

Summary

This commit uses OpenVDB more directly for the voxel remesher, without
the extra indirection of copying to a Blender API. This makes the code
simpler, shorter, and easier to understand (though I didn't observe any
performance improvement).

This also removes the rest of the unused and undocumented OpenVDB C API ,
which was written when Blender's code didn't really use C++, and doesn't serve
a purpose anymore. Those features will be implemented as nodes in the
future anyway (hopefully soon).

Diff Detail

Repository
rB Blender
Branch
cleanup-voxel-remesh-remove-openvdb-capi (branched from master)
Build Status
Buildable 16149
Build 16149: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jul 31 2021, 8:16 PM
Hans Goudey (HooglyBoogly) created this revision.
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/intern/mesh_remesh_voxel.cc
267

Check if this change might revert the normals. (e.g. also see new_mesh_from_openvdb_data)

This revision is now accepted and ready to land.Aug 2 2021, 5:35 PM
Hans Goudey (HooglyBoogly) marked an inline comment as done.Aug 2 2021, 6:24 PM