Paths

Table of Contentst

Differential D12106

T90371: Asset: Drop Material Tooltip.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Aug 2 2021, 4:55 PM.

Tags

Subscribers

Julian Eisel (Severin)

Pratik Borhade (PratikPB2123)

Details

Reviewers

Julian Eisel (Severin)

Group Reviewers

Maniphest Tasks

T90371: As a user I want better feedback when dragging materials so it is clear what happens when dropping the material.

Commits

rBeffc0487106b: T90371: Asset: Drop Material Tooltip.

Summary

This patch changes the drop named material tooltip to give feedback to
the user what is going to happen when they invoke the change.

There are 3 states:

"": Operator will be canceled as not all data is present (dropping on background.)
"Drop <named material> on <object name> (slot <slot number>, replacing <current material in slot>).
"Drop <named material> on <object name> (slot <slot number).

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Aug 2 2021, 4:55 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B16172: Diff 40222.Aug 2 2021, 4:55 PM

Remove unused predeclaration.
Silenced compiler warning.
Fix unneeded loading of assets.

Harbormaster completed remote builds in B16173: Diff 40227.Aug 2 2021, 5:27 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 2 2021, 5:29 PM

Jeroen Bakker (jbakker) added a project: Asset Browser.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added a reviewer: Asset Browser.

Jeroen Bakker (jbakker) added a parent revision: D12056: T90372: Assets: When dropping material use active material slot..

Looks good mostly! ED_view3d_give_base_under_cursor() isn't entirely cheap, but we'll have to accept that if we want good mouse hover feedback.

source/blender/editors/object/object_relations.c
2736	Can we just return `NULL` here?

Jeroen Bakker (jbakker) added inline comments.Aug 2 2021, 7:07 PM

source/blender/editors/include/ED_object.h
57	Remove unused define.
source/blender/editors/object/object_relations.c
2736	That would display the operator name but we could ask feedback from users

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 3 2021, 8:26 AM

Pratik Borhade (PratikPB2123) added a subscriber: Pratik Borhade (PratikPB2123).Aug 3 2021, 8:27 AM

Jeroen Bakker (jbakker) marked an inline comment as done.Aug 3 2021, 8:48 AM

Julian Eisel (Severin) accepted this revision.Aug 3 2021, 9:49 AM

This revision is now accepted and ready to land.Aug 3 2021, 9:49 AM

Jeroen Bakker (jbakker) retitled this revision from Fix T90371: Asset: Drop Material Tooltip. to T90371: Asset: Drop Material Tooltip..Aug 4 2021, 8:37 AM

Closed by commit rBeffc0487106b: T90371: Asset: Drop Material Tooltip. (authored by Jeroen Bakker (jbakker)). · Explain WhyAug 4 2021, 9:00 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rBeffc0487106b: T90371: Asset: Drop Material Tooltip..

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

include/

4 lines

object/

object_relations.c

29 lines

space_outliner/

outliner_dragdrop.c

8 lines

space_view3d/

16 lines

windowmanager/

4 lines

intern/

7 lines

Diff 40296

source/blender/editors/include/ED_object.h

Loading...

source/blender/editors/object/object_relations.c

Loading...

source/blender/editors/space_outliner/outliner_dragdrop.c

Loading...

source/blender/editors/space_view3d/space_view3d.c

Loading...

source/blender/windowmanager/WM_types.h

Loading...

source/blender/windowmanager/intern/wm_dragdrop.c

Loading...