Fix T90087: Assigning object data doesn't copy vertex groups
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Aug 3 2021, 3:38 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
Jacques Lucke (JacquesLucke)

Maniphest Tasks

T90087: data copy is ommitting vgroups

Commits

rB263fa406cd2b: Fix T90087: Assigning object data doesn't copy vertex groups

Summary

Assigning a mesh seems to do its own parameter copying, which
means we need to manual copy its vertex groups here.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Aug 3 2021, 3:38 AM

Hans Goudey (HooglyBoogly) created this revision.

Harbormaster completed remote builds in B16180: Diff 40244.Aug 3 2021, 3:38 AM

Maybe you would look at this Campbell? The fix is quite simple, but I just feel it's odd to have to do this manually here. I get the sense this function could be a fair amount simpler than it is.

Hans Goudey (HooglyBoogly) added a task: T90087: data copy is ommitting vgroups.Aug 3 2021, 3:40 AM

Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).Aug 4 2021, 11:43 PM

Jacques Lucke (JacquesLucke) accepted this revision.Aug 5 2021, 3:02 PM

This revision is now accepted and ready to land.Aug 5 2021, 3:02 PM

Closed by commit rB263fa406cd2b: Fix T90087: Assigning object data doesn't copy vertex groups (authored by Hans Goudey (HooglyBoogly)). · Explain WhyAug 6 2021, 1:27 AM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB263fa406cd2b: Fix T90087: Assigning object data doesn't copy vertex groups.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

mesh_convert.c

4 lines

Diff 40386

View Options

source/blender/blenkernel/intern/mesh_convert.c

Fix T90087: Assigning object data doesn't copy vertex groupsClosedPublicActions