Details

Reviewers

Brecht Van Lommel (brecht)
Andy Goralczyk (eyecandy)

Commits

rC814e52843ba0: More flexible gi approximation ao distance control
rBc18d91918fbb: Cycles: More flexible GI Approximation AO distance control

Summary

The goal: allow to easily use AO approximation in scenes which combines
both small and large scale objects.

The idea: use per-object AO distance which will allow to override world
settings. Instancer object will "propagate" its AO distance to all its
instances unless the instance defines own distance (this allows to
modify AO distance in the shot files, without requiring to modify props
used in the shots.

Diff Detail

Repository

rB Blender

Branch

cycles_object_ao_distance (branched from master)

Build Status

Buildable 16208
Build 16208: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Aug 3 2021, 12:36 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B16184: Diff 40256.Aug 3 2021, 12:36 PM

HEYPictures (HEYPictures) awarded a token.Aug 3 2021, 12:52 PM

Support split kernel
Gray out object GI panel when scene GI is disabled

The benchmark doesn't make me excited:

                                         master               new
barbershop_interior                      108.9230s            108.8810s
bmw27                                    20.7864s             20.6875s
classroom                                59.9108s             59.4715s
junkshop                                 40.0827s             40.0591s
monster                                  85.1941s             86.2019s
pabellon                                 26.7460s             26.7772s

1% in the monster scene seems a bit too much.
Maybe there is something we can do to mitigate this, or maybe we don't
consider it a stopper (especially if in the Cycles X the impact will be
lower due to different kernel organization?)

Harbormaster completed remote builds in B16193: Diff 40276.Aug 3 2021, 6:10 PM

Sergey Sharybin (sergey) edited the summary of this revision. (Show Details)Aug 3 2021, 6:10 PM

Alaska (Alaska) awarded a token.Aug 4 2021, 4:38 AM

Use more clear naming which object is expected to be.

Additionally, did a quick test with Cycles X:

                                         cycles-x             new                  
barbershop_interior                      13.6263s             13.5964s             
bmw27                                    9.0782s              8.9319s              
classroom                                17.1637s             17.1616s             
junkshop                                 18.2349s             18.2742s             
monster                                  9.1487s              9.1452s              
pabellon                                 7.8236s              7.8405s

Think it is acceptable timing.

Brecht, one confusing thing is that sometimes we use sect->object and
sometimes intersection_get_object (which does object lookup from a
primitive when object is OBJECT_NONE). Guess the latter one is what we
should be using?

Harbormaster completed remote builds in B16208: Diff 40298.Aug 4 2021, 10:02 AM

Use sd->object instead of isect->object resolving the following:

Makes sure that the object is always properly intialized (shader data does lookup of an object from primitive when needed).

Resolves speed regression with the monster scene:

                                         master               new
barbershop_interior                      108.0730s            108.6620s
bmw27                                    20.6307s             21.0102s
classroom                                59.6964s             59.8473s
junkshop                                 40.1238s             40.1425s
monster                                  85.7865s             85.5697s
pabellon                                 26.7905s             26.9822s

The shader data is re-used between volume and surface, but in the main
integration loop the shader data is initialized for surface after it is
used for volume, so seems that this is valid to use shader data to know
last object.

Harbormaster completed remote builds in B16212: Diff 40307.Aug 4 2021, 11:25 AM

Brecht Van Lommel (brecht) accepted this revision.Aug 4 2021, 4:43 PM

This revision is now accepted and ready to land.Aug 4 2021, 4:43 PM

Closed by commit rBc18d91918fbb: Cycles: More flexible GI Approximation AO distance control (authored by Sergey Sharybin (sergey)). · Explain WhyAug 4 2021, 5:28 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rBc18d91918fbb: Cycles: More flexible GI Approximation AO distance control.

Brecht Van Lommel (brecht) added a commit: rC814e52843ba0: More flexible gi approximation ao distance control.Jan 27 2022, 11:28 PM

Cycles: More flexible GI Approximation AO distance control
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 40298

intern/cycles/blender/addon/properties.py

intern/cycles/blender/addon/ui.py

intern/cycles/blender/blender_object.cpp

intern/cycles/kernel/kernel_bake.h

intern/cycles/kernel/kernel_path.h

intern/cycles/kernel/kernel_path_branched.h

intern/cycles/kernel/kernel_types.h

intern/cycles/kernel/split/kernel_scene_intersect.h

intern/cycles/render/object.h

intern/cycles/render/object.cpp

Cycles: More flexible GI Approximation AO distance controlClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40298

intern/cycles/blender/addon/properties.py

intern/cycles/blender/addon/ui.py

intern/cycles/blender/blender_object.cpp

intern/cycles/kernel/kernel_bake.h

intern/cycles/kernel/kernel_path.h

intern/cycles/kernel/kernel_path_branched.h

intern/cycles/kernel/kernel_types.h

intern/cycles/kernel/split/kernel_scene_intersect.h

intern/cycles/render/object.h

intern/cycles/render/object.cpp

Cycles: More flexible GI Approximation AO distance control
ClosedPublic
Actions

Revision Contents
Changeset List