Page MenuHome
Differential D12126

Line Art feature update: Trimming edges right at the image border
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on Aug 4 2021, 10:45 AM.

Details

Reviewers
Antonio Vazquez (antoniov)
Group Reviewers
Grease Pencil
User Interface
Maniphest Tasks
T87739: Line Art further improvement list
Commits
rBec831ce5df86: LineArt: Trimming edges right at the image border
Summary

This option allows the edge to end right at the border instead of extending beyond. Useful when having multiple camera setup where you want the border to be clean.

Also moved overscan option down inside "Composition" sub panel so it makes more sense.

Gif for effect:

Diff Detail

Repository
rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.Aug 4 2021, 10:45 AM
YimingWu (NicksBest) created this revision.
YimingWu (NicksBest) added a task: T87739: Line Art further improvement list.
Antonio Vazquez (antoniov) requested changes to this revision.Sep 11 2021, 10:51 AM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).

In general looks ok, just small comments. Just set as request changes to avoid automatic approval.

source/blender/gpencil_modifiers/intern/lineart/lineart_chain.c
937

IIRC the variable names must be lowercase, only #define can be uppercase

993

Could you use LISTBASE_FOREACH_MUTABLE?

This revision now requires changes to proceed.Sep 11 2021, 10:51 AM
YimingWu (NicksBest) marked 2 inline comments as done.Sep 11 2021, 1:19 PM
YimingWu (NicksBest) added inline comments.
source/blender/gpencil_modifiers/intern/lineart/lineart_chain.c
993

I just checked the marco, it will assign iter_next during looping which will override my assign, so I need to write it this way.

YimingWu (NicksBest) updated this revision to Diff 41701.Sep 11 2021, 1:20 PM
YimingWu (NicksBest) marked an inline comment as done.

Updated to latest master.

Note: Requres D12047

Antonio Vazquez (antoniov) accepted this revision as: Antonio Vazquez (antoniov).Sep 20 2021, 6:34 PM
Antonio Vazquez (antoniov) added a subscriber: Matias Mendiola (mendio).

@Matias Mendiola (mendio) could you review UI?

Antonio Vazquez (antoniov) added a comment.Sep 20 2021, 7:11 PM

@YimingWu (NicksBest) We tried to apply the patch to review UI, but the patch fails to apply. Could you rebase the patch?

YimingWu (NicksBest) updated this revision to Diff 42138.Sep 21 2021, 8:31 AM

Updated to latest. Note: Requires D12047.

Matias Mendiola (mendio) added a comment.Sep 22 2021, 3:51 PM
In D12126#328182, @YimingWu (NicksBest) wrote:

Updated to latest. Note: Requires D12047.

@YimingWu (NicksBest) in order to test patches, we need to have patches that can be tested without relying on others.
Could you please arrange this and all the related patches so that they can be tested on their own?

YimingWu (NicksBest) added a comment.Sep 23 2021, 6:44 AM

Will do. Just a moment please

YimingWu (NicksBest) updated this revision to Diff 42288.Sep 23 2021, 8:10 AM

Updated for ease of testing by including parent patches.

When committing I'll only include this specific diff.

Matias Mendiola (mendio) accepted this revision as: Grease Pencil.Sep 23 2021, 3:12 PM
This revision is now accepted and ready to land.Sep 23 2021, 3:12 PM
Closed by commit rBec831ce5df86: LineArt: Trimming edges right at the image border (authored by YimingWu (NicksBest)). · Explain WhyOct 26 2021, 6:11 PM
This revision was automatically updated to reflect the committed changes.
YimingWu (NicksBest) added a commit: rBec831ce5df86: LineArt: Trimming edges right at the image border.

Revision Contents
Changeset List

PathSize
source/
blender/
gpencil_modifiers/
intern/
13 lines
lineart/
8 lines
156 lines
6 lines
makesdna/
8 lines
1 line
makesrna/
intern/
8 lines

Diff 41701

View Options

source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/MOD_lineart.h

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_chain.c

Loading...
View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

Loading...
View Options

source/blender/makesdna/DNA_gpencil_modifier_types.h

Loading...
View Options

source/blender/makesdna/DNA_lineart_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_gpencil_modifier.c

Loading...