Page MenuHome
Differential D12133

Render: move Cycles visibility, holdout and shadow catcher properties to Blender
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Aug 4 2021, 8:48 PM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rBca64bd0aacda: Render: move Cycles visibility, holdout and shadow catcher properties to Blender
Summary

The immediate reason for this is that we want to be able to initialize them
to different defaults for light objects, which is hard with Python properties.
But in general it is useful to be able to share these with other renderers.

As a side effect, Eevee now supports a per-object holdout instead of only
per-collection.

Diff Detail

Repository
rB Blender
Branch
move-flag (branched from master)
Build Status
Buildable 16227
Build 16227: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Aug 4 2021, 8:48 PM
Brecht Van Lommel (brecht) created this revision.
Harbormaster completed remote builds in B16227: Diff 40332.Aug 4 2021, 8:48 PM
Brecht Van Lommel (brecht) added a comment.Aug 4 2021, 8:54 PM

Note this is a patch for master.

Sergey Sharybin (sergey) accepted this revision.Aug 5 2021, 10:57 AM
Sergey Sharybin (sergey) added inline comments.
source/blender/blenkernel/intern/object.c
2088

How does Cycles react to shadow catcher on light?

This revision is now accepted and ready to land.Aug 5 2021, 10:57 AM
Closed by commit rBca64bd0aacda: Render: move Cycles visibility, holdout and shadow catcher properties to Blender (authored by Brecht Van Lommel (brecht)). · Explain WhyAug 5 2021, 5:23 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rBca64bd0aacda: Render: move Cycles visibility, holdout and shadow catcher properties to Blender.
Jesse Yurkovich (deadpin) mentioned this in T91520: cycles.is_holdout no longer works in 3.0.Sep 20 2021, 4:05 AM

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
addon/
21 lines
19 lines
6 lines
13 lines
release/
scripts/
startup/
bl_ui/
4 lines
source/
blender/
blenkernel/
2 lines
intern/
2 lines
6 lines
blenloader/
intern/
37 lines
makesdna/
16 lines
makesrna/
intern/
51 lines

Diff 40332

View Options

intern/cycles/blender/addon/properties.py

Loading...
View Options

intern/cycles/blender/addon/ui.py

Loading...
View Options

intern/cycles/blender/blender_object.cpp

Loading...
View Options

intern/cycles/blender/blender_util.h

Loading...
View Options

release/scripts/startup/bl_ui/properties_object.py

Loading...
View Options

source/blender/blenkernel/BKE_blender_version.h

Loading...
View Options

source/blender/blenkernel/intern/layer.c

Loading...
View Options

source/blender/blenkernel/intern/object.c

Loading...
View Options

source/blender/blenloader/intern/versioning_cycles.c

Loading...
View Options

source/blender/makesdna/DNA_object_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_object.c

Loading...