Page MenuHome

Tests: Custom Data comparison for generic attributes
ClosedPublic

Authored by Himanshi Kalra (calra) on Aug 5 2021, 12:16 PM.

Details

Summary

Generic attributes CD_PROP_* comparison is added in customdata_compare
Checks for built-in as well as user created attributes.

Diff Detail

Repository
rB Blender

Event Timeline

Himanshi Kalra (calra) requested review of this revision.Aug 5 2021, 12:16 PM
Himanshi Kalra (calra) created this revision.
  • Remove unwanted formatting changes
  • Remove extra comments
Jacques Lucke (JacquesLucke) requested changes to this revision.Aug 5 2021, 2:21 PM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/intern/mesh.c
392

There is no need to abbreviate the words here.

484

Missing break, some in the cases below.

487

This i shadows a previous declaration. You can remove the function-wide declaration of i and declare it in the for loops where it is used.
The same scope reduction should be done for l1 and l2 at some point, but that can be done later.

499

Remove unnecessary newlines.

500

This is missing [i], same below.

This revision now requires changes to proceed.Aug 5 2021, 2:21 PM
Himanshi Kalra (calra) marked 5 inline comments as done.
  • Addressed comments

Only got some minor code style comments now. I assume you tested that this does not break existing tests.

source/blender/blenkernel/intern/mesh.c
509

Remove unnecessary newlines between individual cases.

510

Use clang format.

This revision is now accepted and ready to land.Aug 5 2021, 4:18 PM
  • Minor formatting, enforcing Clang
  • Removing Visual Studio squiggly lines
Himanshi Kalra (calra) marked 2 inline comments as done.Aug 5 2021, 8:22 PM