Paths

Table of Contentst

Differential D12137

Tests: Custom Data comparison for generic attributes
ClosedPublic
Actions

Authored by Himanshi Kalra (calra) on Aug 5 2021, 12:16 PM.

Tags

None

Subscribers

Jacques Lucke (JacquesLucke)

Details

Reviewers

Jacques Lucke (JacquesLucke)

Commits

rB92edf37997c2: Add custom data comparison for generic attributes

Summary

Generic attributes CD_PROP_* comparison is added in customdata_compare
Checks for built-in as well as user created attributes.

Diff Detail

Repository: rB Blender

Event Timeline

Himanshi Kalra (calra) requested review of this revision.Aug 5 2021, 12:16 PM

Himanshi Kalra (calra) created this revision.

Harbormaster completed remote builds in B16238: Diff 40350.Aug 5 2021, 12:16 PM

Remove unwanted formatting changes

Harbormaster completed remote builds in B16239: Diff 40351.Aug 5 2021, 12:26 PM

Remove extra comments

Harbormaster completed remote builds in B16240: Diff 40352.Aug 5 2021, 12:33 PM

Jacques Lucke (JacquesLucke) requested changes to this revision.Aug 5 2021, 2:21 PM

Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).

Jacques Lucke (JacquesLucke) added inline comments.

source/blender/blenkernel/intern/mesh.c
392	There is no need to abbreviate the words here.
484	Missing `break`, some in the cases below.
487	This `i` shadows a previous declaration. You can remove the function-wide declaration of `i` and declare it in the `for` loops where it is used. The same scope reduction should be done for `l1` and `l2` at some point, but that can be done later.
499	Remove unnecessary newlines.
500	This is missing `[i]`, same below.

This revision now requires changes to proceed.Aug 5 2021, 2:21 PM

Addressed comments

Harbormaster completed remote builds in B16246: Diff 40359.Aug 5 2021, 3:14 PM

Only got some minor code style comments now. I assume you tested that this does not break existing tests.

source/blender/blenkernel/intern/mesh.c
509	Remove unnecessary newlines between individual cases.
510	Use clang format.

This revision is now accepted and ready to land.Aug 5 2021, 4:18 PM

Minor formatting, enforcing Clang
Removing Visual Studio squiggly lines

Harbormaster completed remote builds in B16252: Diff 40376.Aug 5 2021, 8:21 PM

Himanshi Kalra (calra) marked 2 inline comments as done.Aug 5 2021, 8:22 PM

Closed by commit rB92edf37997c2: Add custom data comparison for generic attributes (authored by Himanshi Kalra (calra)). · Explain WhyAug 5 2021, 8:40 PM

This revision was automatically updated to reflect the committed changes.

Himanshi Kalra (calra) added a commit: rB92edf37997c2: Add custom data comparison for generic attributes.

Habib Gahbiche (zazizizou) mentioned this in D11798: Tests: add edit-mesh operator tests.Sep 5 2021, 12:23 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

95 lines

Diff 40379

source/blender/blenkernel/intern/mesh.c

Loading...