Differential D12160

Fix real_snow slow processing
AbandonedPublic
Actions

Authored by Drew Perttula (drewp) on Aug 7 2021, 11:30 PM.

Details

Reviewers: None

Summary

Cases with many faces that point down are especially improved.

See https://youtu.be/4v8PhgC5Zuo for how I used py-spy to find this issue.

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Drew Perttula (drewp) requested review of this revision.Aug 7 2021, 11:30 PM

Drew Perttula (drewp) created this revision.

Greg Zaal (gregzaal) removed a reviewer: Add-ons (Community).Aug 8 2021, 12:24 AM

Ankit Meel (ankitm) added a project: Add-ons (Community).Aug 8 2021, 5:48 AM

Robert Guetzkow (rjg) added a subscriber: Robert Guetzkow (rjg).Aug 8 2021, 11:12 AM

Marco (nacioss) awarded a token.Aug 8 2021, 11:59 AM

Hey @Drew Perttula (drewp) I'm the author of the add-on. Thank you very much for finding what was slowing down the process! Great work!
Just went ahead and added the changes to the repo https://github.com/marcopavanello/real-snow , hope it's ok for you to have your name in the list of authors in the bl_info.
Thank you again!

Fran Marz (franMarz) awarded a token.Aug 8 2021, 2:35 PM

Ankit Meel (ankitm) abandoned this revision.Aug 9 2021, 5:06 AM

Ankit Meel (ankitm) added a subscriber: Ankit Meel (ankitm).

Marco (nacioss) mentioned this in T90594: Real Snow update.Aug 11 2021, 12:01 AM