Page MenuHome

Compositor: Full frame Bokeh Blur and Blur nodes
ClosedPublic

Authored by Manuel Castilla (manzanilla) on Aug 8 2021, 8:30 PM.

Details

Summary

Adds full frame implementation to these nodes operations.

When enabling "extend bounds" node option, tiled implementation
result is slightly different because it's using TranslateOperation
with bilinear sampling for centering.
Full frame always uses nearest to don't lose image quality.
It has the disadvantage of causing image jiggling on backdrop
when switching size values as it's not pixel perfect.
This is fixed by rounding to even.

Diff Detail

Repository
rB Blender
Branch
cmp-nodes-blur (branched from master)
Build Status
Buildable 16286
Build 16286: arc lint + arc unit

Event Timeline

Manuel Castilla (manzanilla) requested review of this revision.Aug 8 2021, 8:30 PM
Manuel Castilla (manzanilla) created this revision.
Jeroen Bakker (jbakker) requested changes to this revision.Aug 9 2021, 9:18 AM

Just a small cleanup needed.

source/blender/compositor/operations/COM_BokehBlurOperation.cc
269

Should we move this to BLI_math?

This revision now requires changes to proceed.Aug 9 2021, 9:18 AM
  • Move round_to_even to BLI_math
Manuel Castilla (manzanilla) marked an inline comment as done.Aug 9 2021, 9:40 PM
This revision is now accepted and ready to land.Aug 16 2021, 11:20 AM