Details

Reviewers

Clément Foucault (fclem)
Julian Eisel (Severin)
Sybren A. Stüvel (sybren)
Bastien Montagne (mont29)

Maniphest Tasks

T90576: As a user I want to apply an material to the material slot under the mouse cursor.

Commits

rB54f5c174a8cf: Asset: Dropping Material assets on material slot under mouse cursor.

Summary

This patch allows dropping material assets from material slot under the mouse
cursor. Before this change the material slot had to be hand-picked from the
properties panel.

For consistency it is chosen to do this in any shading mode as the tooltip shows
what is exactly going to happen during release.

The feature also works for other object types than Meshes as it uses the drawn surface on the
GPU to detect the material slots. Performance of this patch has been tested with AMD GCN3.0
cards and are very responsive.

Video demonstrating material slot selection.

Diff Detail

Repository: rB Blender

Event Timeline

Jeroen Bakker (jbakker) created this revision.Aug 11 2021, 9:20 AM

Harbormaster completed remote builds in B16349: Diff 40578.Aug 11 2021, 9:20 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 11 2021, 9:23 AM

Jeroen Bakker (jbakker) added reviewers: Clément Foucault (fclem), Julian Eisel (Severin), Sybren A. Stüvel (sybren), Bastien Montagne (mont29).

Jeroen Bakker (jbakker) added a project: Asset Browser.

Jeroen Bakker (jbakker) added a task: T90576: As a user I want to apply an material to the material slot under the mouse cursor..

Silenced clang-tidy warnings.
Fixed crash when object has no uvs.

Harbormaster completed remote builds in B16351: Diff 40582.Aug 11 2021, 11:11 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 11 2021, 11:11 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 11 2021, 11:15 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 11 2021, 12:14 PM

William Reynish (billreynish) awarded a token.Aug 11 2021, 1:44 PM

Fran Marz (franMarz) awarded a token.Aug 11 2021, 4:20 PM

One nice thing to note, this implementation uses OpenGL picking, so it also works for curves or other object types with "no real geometry". Using ray-casting this wouldn't work.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 16 2021, 4:36 PM

Merge branch 'master' into temp-T90576-asset-browser-drop-on-material-slot
Remove incorrect assert statement.
Moved material slot support detection to BKE_object.
Add support for material slot selection of hair.

Harbormaster completed remote builds in B16456: Diff 40767.Aug 17 2021, 8:59 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 17 2021, 9:01 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 17 2021, 9:31 AM

Jeroen Bakker (jbakker) added a project: EEVEE & Viewport.

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Aug 17 2021, 9:43 AM

Jeroen Bakker (jbakker) requested review of this revision.Aug 17 2021, 9:48 AM

Since this mostly touches the draw manager, there isn't much I can contribute in terms of code review, although things seem reasonable.
As a feature I think this is great to have, although I'm wondering if it should be optional in some way. Best to first let people test this in practice, then we can decide to make things optional still.

Selection as a whole is getting a bit too much inside the draw manager but it's a lesser evil than having a dedicated selection engine for overlays.
Maybe one day we will just have this dedicated engine with simpler drawing for overlays but I doubt.

source/blender/draw/intern/draw_manager_data.c
801 ↗	(On Diff #40767)	Why are you using a separated argument with a new macro instead of using `DRW_select_load_id` like many other areas do? Also I'm pretty sure this `+` should be an `\|` although it may do the same thing for most values.

This revision now requires changes to proceed.Aug 31 2021, 9:39 AM

Alaska (Alaska) awarded a token.Aug 31 2021, 9:47 AM

Reverted DRW_shgroup_call_with_subselection.

Harbormaster completed remote builds in B16711: Diff 41255.Aug 31 2021, 10:21 AM

Jeroen Bakker (jbakker) marked an inline comment as done.Aug 31 2021, 10:21 AM

Jeroen Bakker (jbakker) added inline comments.

source/blender/draw/intern/draw_manager_data.c
801 ↗	(On Diff #40767)	I haven't done with selection since the introduction of the selection engine. Will test if `DRW_select_load_id` leads to the same behavior.

Clément Foucault (fclem) accepted this revision.Sep 7 2021, 6:47 PM

This revision is now accepted and ready to land.Sep 7 2021, 6:47 PM

Closed by commit rB54f5c174a8cf: Asset: Dropping Material assets on material slot under mouse cursor. (authored by Jeroen Bakker (jbakker)). · Explain WhySep 8 2021, 8:48 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) marked an inline comment as done.

Jeroen Bakker (jbakker) added a commit: rB54f5c174a8cf: Asset: Dropping Material assets on material slot under mouse cursor..

Antonio Vazquez (antoniov) mentioned this in rB94d2736dfb33: Fix T92046: Mesh to GPencil fails because materials are not created.Oct 8 2021, 4:49 PM

Asset: Dropping Material assets on material slot under mouse cursor.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 41561

source/blender/blenkernel/BKE_object.h

source/blender/blenkernel/intern/object.c

source/blender/draw/DRW_engine.h

source/blender/draw/engines/basic/basic_engine.c

source/blender/draw/intern/DRW_render.h

source/blender/draw/intern/draw_manager.h

source/blender/draw/intern/draw_manager.c

source/blender/editors/include/ED_view3d.h

source/blender/editors/object/object_relations.c

source/blender/editors/space_view3d/view3d_select.c

source/blender/editors/space_view3d/view3d_view.c

Asset: Dropping Material assets on material slot under mouse cursor.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41561

source/blender/blenkernel/BKE_object.h

source/blender/blenkernel/intern/object.c

source/blender/draw/DRW_engine.h

source/blender/draw/engines/basic/basic_engine.c

source/blender/draw/intern/DRW_render.h

source/blender/draw/intern/draw_manager.h

source/blender/draw/intern/draw_manager.c

source/blender/editors/include/ED_view3d.h

source/blender/editors/object/object_relations.c

source/blender/editors/space_view3d/view3d_select.c

source/blender/editors/space_view3d/view3d_view.c

Asset: Dropping Material assets on material slot under mouse cursor.
ClosedPublic
Actions

Revision Contents
Changeset List