Fix T89027: [2.93 only] pose slide factor wrong in redo popup
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 11 2021, 9:22 AM.

Details

Reviewers

Christoph Lendenfeld (ChrisLend)
Sybren A. Stüvel (sybren)
Hans Goudey (HooglyBoogly)

Commits

rB1eeae9be1531: [2.93 only] pose slide factor wrong in redo popup

Summary

Originally this was caused by rBc71a8e837616: UI: Fix incorrect RNA percentage property definitions.
Above commit wasnt renaming RNA definitions, but not the occurances were
RNA values were set.

In 3.0, we had improvements to pose-sliding tools (D9054) where this was
somewhat ironed out (only partially, see D12187).

But since the pose-sliding improvements are not part of 2.93, we have to
correct this in 2.93 ONLY.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 11 2021, 9:22 AM

Philipp Oeser (lichtwerk) created this revision.

Philipp Oeser (lichtwerk) mentioned this in T89027: After applying the Pose Breakdowner, the Factor in the popup menu does not work..

Ah, thanks, I had missed the detail that 2.93 didn't get the pose slide tool.

This revision is now accepted and ready to land.Aug 11 2021, 2:10 PM

@Jeroen Bakker (jbakker): can I commit this to 2.93 without any further precautions (asking since this is my first time committing to a release branch only)?
Just checkout blender-v2.93-release, make update, apply, commit, right?

looks good to me
good job hunting that down

In D12191#315799, @Philipp Oeser (lichtwerk) wrote:

@Jeroen Bakker (jbakker): can I commit this to 2.93 without any further precautions (asking since this is my first time committing to a release branch only)?
Just checkout blender-v2.93-release, make update, apply, commit, right?

AFAIK that's indeed the process.

Closed by commit rB1eeae9be1531: [2.93 only] pose slide factor wrong in redo popup (authored by Philipp Oeser (lichtwerk)). · Explain WhyAug 12 2021, 5:09 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB1eeae9be1531: [2.93 only] pose slide factor wrong in redo popup.