Page MenuHome
Differential D12192

Add cutom data color property
ClosedPublic
Actions

Authored by Himanshi Kalra (calra) on Aug 11 2021, 11:02 AM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBc48a01a88add: Add cutom data color property for mesh comparison
Summary

Add color data type comparison for meshes, adding it as part of comparing meshes with geometry nodes.

Diff Detail

Repository
rB Blender
Branch
cd_prop_color (branched from master)
Build Status
Buildable 16350
Build 16350: arc lint + arc unit

Event Timeline

Himanshi Kalra (calra) requested review of this revision.Aug 11 2021, 11:02 AM
Himanshi Kalra (calra) created this revision.
Harbormaster completed remote builds in B16350: Diff 40581.Aug 11 2021, 11:02 AM
Himanshi Kalra (calra) updated this revision to Diff 40584.Aug 11 2021, 11:52 AM

fix: forgot the thresh

Harbormaster completed remote builds in B16352: Diff 40584.Aug 11 2021, 11:52 AM
Jacques Lucke (JacquesLucke) accepted this revision.Aug 11 2021, 1:24 PM
This revision is now accepted and ready to land.Aug 11 2021, 1:24 PM
Jacques Lucke (JacquesLucke) requested changes to this revision.Aug 11 2021, 1:32 PM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/intern/mesh.c
1

Please check this: rB32c687b5ec43463d7d419313c4eecf1ad629f61e.

This revision now requires changes to proceed.Aug 11 2021, 1:32 PM
Himanshi Kalra (calra) updated this revision to Diff 40591.Aug 11 2021, 2:45 PM
  • Remove UTF-8 BOM
Harbormaster completed remote builds in B16358: Diff 40591.Aug 11 2021, 2:45 PM
Himanshi Kalra (calra) marked an inline comment as done.Aug 11 2021, 2:48 PM
Jacques Lucke (JacquesLucke) accepted this revision.Aug 11 2021, 2:51 PM
This revision is now accepted and ready to land.Aug 11 2021, 2:51 PM
Evan Wilson (EAW) added a subscriber: Evan Wilson (EAW).Aug 11 2021, 11:32 PM

I just saw the word “color” and decided to check it out, but there isn’t any info. Mind adding a sentence or two as to what this is about in the description? Thanks 🤗

Himanshi Kalra (calra) edited the summary of this revision. (Show Details)Aug 16 2021, 8:41 AM
Closed by commit rBc48a01a88add: Add cutom data color property for mesh comparison (authored by Himanshi Kalra (calra)). · Explain WhyAug 16 2021, 9:00 AM
This revision was automatically updated to reflect the committed changes.
Himanshi Kalra (calra) added a commit: rBc48a01a88add: Add cutom data color property for mesh comparison.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
15 lines

Diff 40581

View Options

source/blender/blenkernel/intern/mesh.c

Loading...