Fix T90595: some VSE strip properties do not identify strip name in anim channel names
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Aug 11 2021, 2:34 PM.

Details

Reviewers

Richard Antalik (ISS)
Sybren A. Stüvel (sybren)
Jeroen Bakker (jbakker)

Maniphest Tasks

T90595: VSE/Graph: Certain animated properties of visual strips do not identify strip name in graph editor

Commits

rB77744b581d08: Fix T90595: some VSE strip properties do not identify strip name in anim

Summary

Working with multiple strips keyframes was unneccessarily difficult in
Animation Editors (since some anim channels could not be distinguished).

Namely Crop and Transform are nested structs (nested under
Sequence), so these were just displaying the raw struct name.
Also strip modifiers did not have their strip name in their channel
names. Now include the strip name for these.

before

after

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Aug 11 2021, 2:34 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B16357: Diff 40589.Aug 11 2021, 2:34 PM

Philipp Oeser (lichtwerk) added projects: VFX & Video, Video Sequencer, Animation & Rigging.Aug 11 2021, 2:35 PM

Philipp Oeser (lichtwerk) mentioned this in T90595: VSE/Graph: Certain animated properties of visual strips do not identify strip name in graph editor.

Philipp Oeser (lichtwerk) added subscribers: Sybren A. Stüvel (sybren), Francesco Siddi (fsiddi).

Richard Antalik (ISS) accepted this revision.Aug 11 2021, 2:44 PM

This revision is now accepted and ready to land.Aug 11 2021, 2:44 PM

Just noticed a memleak, will need to correct before committing...

fix memleak

Harbormaster completed remote builds in B16364: Diff 40600.Aug 11 2021, 4:53 PM

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Aug 11 2021, 6:30 PM

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/editors/animation/anim_ipo_utils.c
138–140	Some grammar thingies here.
141–143	IMO this is a bit more readable with the "or" part separated into another if statement (at the cost of another indentation of course).

Just to make sure if this OK performance wise (string lookups run on certain UI refreshes), will add corresponding reviewers.

Note though that this only runs for properties not directly on an ID (there are string lookups right above this change for "bones[" and "constraints[" that always run, so...)

Francesco Siddi (fsiddi) awarded a token.Aug 12 2021, 7:23 PM

If we want to remove the malloc/free we should move this code to CPP and use Blender::StringRef.