Details

Reviewers

Maniphest Tasks

T78995: Poor performance in Timeline, Dope Sheet, etc when at the top of the editor.

Commits

rB7f1fe1059506: T78995: Enable keylist threaded drawing.

Summary

This enabled multithreaded building of the keys that needs to be drawn in the timeline (and other action editors).
The patch should be applied on top of D12052.

Test file is a adaptation of the file found in T78995: Poor performance in Timeline, Dope Sheet, etc when at the top of the editor.. It enabled the onion skinning to make sure that it still works.

slow.blend21 MBDownload

On my system AMD Ryzen 3800 it is can get 8 frames per second.

Diff Detail

Repository

rB Blender

Branch

master

Build Status

Buildable 16365
Build 16365: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Aug 11 2021, 4:57 PM

Harbormaster completed remote builds in B16365: Diff 40601.Aug 11 2021, 4:57 PM

Enable keylist threaded drawing.

Rebased with master + D12052.

Harbormaster completed remote builds in B16402: Diff 40666.Aug 13 2021, 10:23 AM

Jeroen Bakker (jbakker) added a parent revision: D12052: Anim: Keylist drawing optimization by using arrays..Aug 13 2021, 10:24 AM

Jeroen Bakker (jbakker) requested review of this revision.Aug 13 2021, 10:33 AM

Jeroen Bakker (jbakker) retitled this revision from Enable keylist threaded drawing. to T78995: Enable keylist threaded drawing..

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added reviewers: Sybren A. Stüvel (sybren), Sebastian Parborg (zeddb).

Jeroen Bakker (jbakker) added projects: Animation & Rigging, Performance.

Jeroen Bakker (jbakker) added a task: T78995: Poor performance in Timeline, Dope Sheet, etc when at the top of the editor..

Jeroen Bakker (jbakker) mentioned this in D12052: Anim: Keylist drawing optimization by using arrays..Aug 13 2021, 10:39 AM

That's awesome man! Just tested the patch, this makes the performance much much better. Without the patch I cant even move the timeline a single frame without waiting for a couple seconds. With the patch it's actually possible to work on those high keyframe files. Granted it's still not blazing fast but its fast enough to be able to get some edits done without ripping the hairs out.

Gavriel Lavi (Gavriel5578) awarded a token.Aug 13 2021, 5:21 PM

@Jeroen Bakker (jbakker) after some testing I noticed that when I select a keyframe in the dope sheet it always selects the very first one rather than the one under the mouse. Idk how I didnt notice that at first haha. In graph editor it selects fine tho.