Page MenuHome

FBX export / subdivision: Write proper boundary rule
ClosedPublic

Authored by Samuli Raivio (bqqbarbhg) on Aug 12 2021, 6:36 PM.

Details

Summary

Currently when exporting a subdivision surface (Geometry / Export Subdivision Surface enabled) the exporter uses a hard-coded BoundaryRule rule of 2 (CreaseAll, meaning hard corners). The subdivision surface modifier has an option for boundary smoothing mode so this patch propagates that information to the FBX exporter.

Example .fbx file with this feature exported from modified Blender 2.93: https://github.com/bqqbarbhg/ufbx/blob/overhaul/data/blender_293x_subsurf_boundary_7400_binary.fbx

Diff Detail

Event Timeline

Samuli Raivio (bqqbarbhg) requested review of this revision.Aug 12 2021, 6:36 PM
Samuli Raivio (bqqbarbhg) created this revision.

Added import support as well.

Hi, thanks for the patch. I think @Bastien Montagne (mont29) can be the reviewer for this patch.

(he has reviewed a few of your previous patches so asking for Bastien Montagne)

May be I am wrong up here :)

Thanks for the reply! I'm still pretty new to this system, is it customary for submitters to request reviewers themselves?

Thanks for the patch!

Regarding process, usually it's better to tag a project and/or the add-on authors, rather than directly assign, yes.

This revision is now accepted and ready to land.Sep 29 2021, 5:58 PM